linux-kernel - Re: [PATCH v2] drm: etnaviv: fix strncpy sizeof argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKq8=3KUFgVzTbaQhSHbKQGPDafHPt28rHW=+D+2CDZeDsfSnQ@mail.gmail.com>
Date:   Tue, 2 Apr 2019 09:30:38 +0800
From:   Bo YU <tsu.yubo@...il.com>
To:     l.stach@...gutronix.de, linux+etnaviv@...linux.org.uk,
        Christian Gmeiner <christian.gmeiner@...il.com>,
        airlied@...ux.ie, Daniel Vetter <daniel@...ll.ch>,
        open list <linux-kernel@...r.kernel.org>
Cc:     etnaviv@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        于波 <yuzibode@....com>
Subject: Re: [PATCH v2] drm: etnaviv: fix strncpy sizeof argument

On Thu, Mar 28, 2019 at 4:09 PM Bo YU <tsu.yubo@...il.com> wrote:
>
> Calling strncpy with a maximum size argument of 64 bytes on destination
> array "domain->name" of size 64 bytes might leave the destination string
> unterminated.
>
> Detected by CoverityScan, CID# 1443992:  Memory - illegal accesses (BUFFER_SIZE_WARNING)
>
> Fixes: 9e2c2e2730126 (drm/etnaviv: add infrastructure to query perf counter)
> Signed-off-by: Bo YU <tsu.yubo@...il.com>
> ---
> v2: accroding to Russell's suggestion, replace strncpy with strlcpy
> ---
>  drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
> index 4227a4006c34..ce178f23e86a 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
> @@ -414,7 +414,7 @@ int etnaviv_pm_query_dom(struct etnaviv_gpu *gpu,
>
>         domain->id = domain->iter;
>         domain->nr_signals = dom->nr_signals;
> -       strncpy(domain->name, dom->name, sizeof(domain->name));
> +       strlcpy(domain->name, dom->name, sizeof(domain->name));
>
>         domain->iter++;
>         if (domain->iter == meta->nr_domains)
> --
> 2.11.0
>
Ping?