linux-kernel - Re: [RFC PATCH 2/4] bus: ti-sysc: Add generic enable/disable functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190402171449.GN49658@atomide.com>
Date:   Tue, 2 Apr 2019 10:14:49 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Roger Quadros <rogerq@...com>
Cc:     nsekhar@...com, s-anna@...com, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 2/4] bus: ti-sysc: Add generic enable/disable
 functions

* Roger Quadros <rogerq@...com> [190402 13:38]:
> For non legacy cases, add generic sysc_enable_module()
> and sysc_disable_module() functions.

Looks OK to me. Can you please add a comment mentioning that we're
not currently blocking clockdomain autoidle? See clkdm_deny_idle()
use in omap_hwmod.c.

> +	if (idlemodes & BIT(SYSC_IDLE_SMART_WKUP)) {
> +		best_mode = SYSC_IDLE_SMART_WKUP;
> +	} else if (idlemodes & BIT(SYSC_IDLE_SMART)) {
> +		best_mode = SYSC_IDLE_SMART;
> +	} else if (idlemodes & SYSC_IDLE_FORCE) {
> +		best_mode = SYSC_IDLE_FORCE;
> +	} else {
> +		dev_err(dev, "%s: invalid midlemode\n", __func__);
> +		return -EINVAL;
> +	}
...

> +	if (idlemodes & BIT(SYSC_IDLE_SMART_WKUP)) {
> +		best_mode = SYSC_IDLE_SMART_WKUP;
> +	} else if (idlemodes & BIT(SYSC_IDLE_SMART)) {
> +		best_mode = SYSC_IDLE_SMART;
> +	} else if (idlemodes & SYSC_IDLE_FORCE) {
> +		best_mode = SYSC_IDLE_FORCE;
> +	} else {
> +		dev_err(dev, "%s: invalid sidlemode\n", __func__);
> +		return -EINVAL;
> +	}

Can you please add a helper function for getting the best
idle mode?

Regards,

Tony