linux-kernel - Re: [RFC PATCH 1/4] ARM: dts: dra7: Keep usb_otg_ss3 and usb_otg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e53664ff-4376-99eb-8fc5-ab335a59085a@ti.com>
Date:   Wed, 3 Apr 2019 11:38:41 +0300
From:   Roger Quadros <rogerq@...com>
To:     Tony Lindgren <tony@...mide.com>
CC:     <nsekhar@...com>, <s-anna@...com>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 1/4] ARM: dts: dra7: Keep usb_otg_ss3 and usb_otg_ss4
 disabled

On 02/04/2019 19:22, Tony Lindgren wrote:
> * Roger Quadros <rogerq@...com> [190402 13:38]:
>> These 2 modules are not present on all families (e.g. AM57).
>> Keep them disabled.
> 
> Can you please add comments to the dtsi file for why "disabled"
> is set? Otherwise we may end up removing them at some point as
> the default should be just enabled with no status property.
> 
> If these devices are really there for some SoCs, we should
> have a separate dtsi for them.

They are there on J6 variants but not on AM5 variants.

OK. I will move them to a separate dtsi and include them in the
right variants.

The patch can be independent of this series.

-- 
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki