linux-kernel - Re: [PATCH] media: dib0700: fix link error for dibx000_i2c_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190403163444.2psjymq5kb3c6ok6@gofer.mess.org>
Date:   Wed, 3 Apr 2019 17:34:44 +0100
From:   Sean Young <sean@...s.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Colin Ian King <colin.king@...onical.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: dib0700: fix link error for dibx000_i2c_set_speed

On Wed, Mar 13, 2019 at 10:16:53PM +0100, Arnd Bergmann wrote:
> When CONFIG_DVB_DIB9000 is disabled, we can still compile code that
> now fails to link against dibx000_i2c_set_speed:
> 
> drivers/media/usb/dvb-usb/dib0700_devices.o: In function `dib01x0_pmu_update.constprop.7':
> dib0700_devices.c:(.text.unlikely+0x1c9c): undefined reference to `dibx000_i2c_set_speed'
> 
> The call sites are both through dib01x0_pmu_update(), which gets
> passed an 'i2c' pointer from dib9000_get_i2c_master(), which has
> returned NULL. Checking this pointer seems to be a good idea
> anyway, and it avoids the link failure.

So I reproduced the link failure with attached config, and your patch
does not fix it.

Sean

> 
> Fixes: b7f54910ce01 ("V4L/DVB (4647): Added module for DiB0700 based devices")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/media/usb/dvb-usb/dib0700_devices.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/media/usb/dvb-usb/dib0700_devices.c b/drivers/media/usb/dvb-usb/dib0700_devices.c
> index 9311f7d4bba5..4cbc64ea17d7 100644
> --- a/drivers/media/usb/dvb-usb/dib0700_devices.c
> +++ b/drivers/media/usb/dvb-usb/dib0700_devices.c
> @@ -2445,6 +2445,8 @@ static int dib9090_tuner_attach(struct dvb_usb_adapter *adap)
>  	if (dvb_attach(dib0090_fw_register, adap->fe_adap[0].fe, i2c, &dib9090_dib0090_config) == NULL)
>  		return -ENODEV;
>  	i2c = dib9000_get_i2c_master(adap->fe_adap[0].fe, DIBX000_I2C_INTERFACE_GPIO_1_2, 0);
> +	if (!i2c)
> +		return -ENODEV;
>  	if (dib01x0_pmu_update(i2c, data_dib190, 10) != 0)
>  		return -ENODEV;
>  	dib0700_set_i2c_speed(adap->dev, 1500);
> @@ -2524,6 +2526,8 @@ static int nim9090md_tuner_attach(struct dvb_usb_adapter *adap)
>  	if (dvb_attach(dib0090_fw_register, adap->fe_adap[0].fe, i2c, &nim9090md_dib0090_config[0]) == NULL)
>  		return -ENODEV;
>  	i2c = dib9000_get_i2c_master(adap->fe_adap[0].fe, DIBX000_I2C_INTERFACE_GPIO_1_2, 0);
> +	if (!i2c)
> +		return -ENODEV;
>  	if (dib01x0_pmu_update(i2c, data_dib190, 10) < 0)
>  		return -ENODEV;
>  
> -- 
> 2.20.0

View attachment "config" of type "text/plain" (206684 bytes)