linux-kernel - Re: [PATCH v2 2/2] mfd: cros_ec: Instantiate the CrOS USB PD logger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Apr 2019 09:35:00 -0700
From:   Guenter Roeck <groeck@...gle.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Gwendal Grignou <gwendal@...omium.org>, jflat@...omium.org,
        kernel@...labora.com, Lee Jones <lee.jones@...aro.org>,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Rajat Jain <rajatja@...gle.com>,
        Dmitry Torokhov <dtor@...omium.org>
Subject: Re: [PATCH v2 2/2] mfd: cros_ec: Instantiate the CrOS USB PD logger driver

On Wed, Apr 3, 2019 at 7:05 AM Enric Balletbo i Serra
<enric.balletbo@...labora.com> wrote:
>
> Add the cros-usbpd-logger driver for logging event data for the USB PD
> charger available in the Embedded Controller on ChromeOS systems. The
> logging feature is logically separate functionality from charge manager,
> hence is instantiated as a different driver.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> ---
> Lee, this is send as separate patch because touches the MFD subsystem,
> apart from that the driver won't be instantiated if [1/2] is not
> merged, which I think is not a problem, it is safe for both go through
> their subsystem separately.
>
> Thanks,
>  Enric
>
> Changes in v2: None
>
Not really. Changes in v2: Dropped unrelated whitespace changes.

Other than that,

Reviewed-by: Guenetr Roeck <linux@...ck-us.net>

>  drivers/mfd/cros_ec_dev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index 0638a0d82d97..3e33fa5b8657 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -612,7 +612,8 @@ static const struct mfd_cell cros_ec_rtc_cells[] = {
>  };
>
>  static const struct mfd_cell cros_usbpd_charger_cells[] = {
> -       { .name = "cros-usbpd-charger" }
> +       { .name = "cros-usbpd-charger" },
> +       { .name = "cros-usbpd-logger" },
>  };
>
>  static const struct mfd_cell cros_ec_platform_cells[] = {
> --
> 2.20.1
>