linux-kernel - Re: [PATCH] staging: rtl8192u: ieee80211: add space around '==' and before '('

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 5 Apr 2019 08:11:47 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Caio Salvador Rohwedder <caiosalvador96@...il.com>,
        gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        lkcamp@...ts.libreplanetbr.org, linux-kernel@...r.kernel.org,
        johnfwhitmore@...il.com
Subject: Re: [PATCH] staging: rtl8192u: ieee80211: add space around '==' and
 before '('

On Fri, Apr 05, 2019 at 10:31:17AM +0800, YueHaibing wrote:
> On 2019/4/5 9:56, Caio Salvador Rohwedder wrote:
> >  			if(!list_empty(pUnusedList)) {
> >  				(*ppTS) = list_entry(pUnusedList->next, struct ts_common_info, list);
> >  				list_del_init(&(*ppTS)->list);
> > -				if(TxRxSelect==TX_DIR) {
> > +				if (TxRxSelect == TX_DIR) {
> >  					struct tx_ts_record *tmp = container_of(*ppTS, struct tx_ts_record, ts_common_info);
> 
> This line seems over 80 characters, may also be fixed.
> 

The 80 character problem isn't really related to the "space required"
problem.  Those would need to be fixed in separate patches.

> In fact, this file has so many code style issues, see
> 
> ./scripts/checkpatch.pl --no-tree -f drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
> 

Yes.  Of course it has millions of style issues.  It's staging code.
Leave it.  We'll fix it little by little.

That said, I kind of would prefer to review patches which fix all the
"space[s] required" checkpatch warnings in a file in one go...

regards,
dan carpenter