lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 5 Apr 2019 10:31:17 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Caio Salvador Rohwedder <caiosalvador96@...il.com>,
        <gregkh@...uxfoundation.org>
CC:     <johnfwhitmore@...il.com>, <devel@...verdev.osuosl.org>,
        <linux-kernel@...r.kernel.org>, <lkcamp@...ts.libreplanetbr.org>
Subject: Re: [PATCH] staging: rtl8192u: ieee80211: add space around '==' and
 before '('


On 2019/4/5 9:56, Caio Salvador Rohwedder wrote:
> Fix checkpatch coding style errors on rtl819x_TSProc.c
> - space required before the open parenthesis '('
> - spaces required around that '=='
> 
> Signed-off-by: Caio Salvador Rohwedder <caiosalvador96@...il.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
> index c76715ffa08b..0af1a87a5545 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
> @@ -373,7 +373,7 @@ bool GetTs(
>  			if(!list_empty(pUnusedList)) {
>  				(*ppTS) = list_entry(pUnusedList->next, struct ts_common_info, list);
>  				list_del_init(&(*ppTS)->list);
> -				if(TxRxSelect==TX_DIR) {
> +				if (TxRxSelect == TX_DIR) {
>  					struct tx_ts_record *tmp = container_of(*ppTS, struct tx_ts_record, ts_common_info);

This line seems over 80 characters, may also be fixed.

In fact, this file has so many code style issues, see

./scripts/checkpatch.pl --no-tree -f drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c

>  					ResetTxTsEntry(tmp);
>  				} else {
> 

Powered by blists - more mailing lists