linux-kernel - Re: [PATCH] drivers/platform/x86/dell-rbtn.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vft=SfD0BEsM8hOUuHKVBa_-p_-mk4c6odrFjkbuYtO1A@mail.gmail.com>
Date:   Fri, 5 Apr 2019 17:04:56 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Pali Rohár <pali.rohar@...il.com>
Cc:     Valdis Klētnieks <valdis.kletnieks@...edu>,
        Darren Hart <dvhart@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/platform/x86/dell-rbtn.c - add missing #include

On Wed, Mar 13, 2019 at 12:46 AM Pali Rohár <pali.rohar@...il.com> wrote:
>
> On Tuesday 12 March 2019 07:26:06 Valdis Klētnieks wrote:
> > Building with W=1 complains:
> >   CC [M]  drivers/platform/x86/dell-rbtn.o
> > drivers/platform/x86/dell-rbtn.c:345:5: warning: no previous prototype for 'dell_rbtn_notifier_register' [-Wmissing-prototypes]
> >   345 | int dell_rbtn_notifier_register(struct notifier_block *nb)
> >       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/platform/x86/dell-rbtn.c:371:5: warning: no previous prototype for 'dell_rbtn_notifier_unregister' [-Wmissing-prototypes]
> >   371 | int dell_rbtn_notifier_unregister(struct notifier_block *nb)
> >       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Can you identify in which commit was introduced this problem? If yes,
> then Fixes: keyword should be added into commit message.
>

Pushed to my review and testing queue, thanks!

P.S. I have added Fixes tag.

> >
> > The real problem is a missing include. Add it to keep dell-rbtn.c and .h in sync
> >
> > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@...edu>
> >
> > diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c
> > index f3afe778001e..d50ca96d99f0 100644
> > --- a/drivers/platform/x86/dell-rbtn.c
> > +++ b/drivers/platform/x86/dell-rbtn.c
> > @@ -17,6 +17,7 @@
> >  #include <linux/acpi.h>
> >  #include <linux/rfkill.h>
> >  #include <linux/input.h>
> > +#include "dell-rbtn.h"
> >
> >  enum rbtn_type {
> >       RBTN_UNKNOWN,
> >
>
> --
> Pali Rohár
> pali.rohar@...il.com



-- 
With Best Regards,
Andy Shevchenko