lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Apr 2019 16:43:04 +0200 From: Noralf Trønnes <noralf@...nnes.org> To: Gerd Hoffmann <kraxel@...hat.com>, dri-devel@...ts.freedesktop.org Cc: sam@...nborg.org, Dave Airlie <airlied@...hat.com>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, open list <linux-kernel@...r.kernel.org>, "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" <virtualization@...ts.linux-foundation.org> Subject: Re: [PATCH v3 5/5] drm/cirrus: rewrite and modernize driver. Den 05.04.2019 11.52, skrev Gerd Hoffmann: > Time to kill some bad sample code people are copying from ;) > > This is a complete rewrite of the cirrus driver. The cirrus_mode_set() > function is pretty much the only function which is carried over largely > unmodified. Everything else is upside down. > > It is a single monster patch. But given that it does some pretty > fundamental changes to the drivers workflow and also reduces the code > size by roughly 70% I think it'll still be alot easier to review than a > longish baby-step patch series. > > Changes summary: > - Given the small amout of video memory (4 MB) the cirrus device has > the rewritten driver doesn't try to manage buffers there. Instead > it will blit (memcpy) the active framebuffer to video memory. > - All gem objects are stored in main memory and are manged using the > new shmem helpers. ttm is out. > - It supports RG16, RG24 and XR24 formats. XR24 gets converted to RG24 > or RG16 at blit time if needed, to avoid the pitch becoming larger > than what the cirrus hardware can handle. > - The simple display pipeline is used. > - The generic fbdev emulation is used. > - It's a atomic driver now. > - It runs wayland. > > Signed-off-by: Gerd Hoffmann <kraxel@...hat.com> > --- Acked-by: Noralf Trønnes <noralf@...nnes.org>
Powered by blists - more mailing lists