linux-kernel - Re: [PATCH v3 05/13] thermal: qoriq: Embed per-sensor data into struct qoriq_tmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHQ1cqEJbXKdoqqwKjkD_yPjv52Y9w+XOOKxqFpPN23q-qnFaw@mail.gmail.com>
Date:   Fri, 5 Apr 2019 11:00:42 -0700
From:   Andrey Smirnov <andrew.smirnov@...il.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     linux-pm@...r.kernel.org, Chris Healy <cphealy@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        Angus Ainslie <angus@...ea.ca>,
        dl-linux-imx <linux-imx@....com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 05/13] thermal: qoriq: Embed per-sensor data into
 struct qoriq_tmu_data

On Thu, Apr 4, 2019 at 12:57 AM Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:
>
> On 01/04/2019 06:14, Andrey Smirnov wrote:
> > Embed per-sensor data into struct qoriq_tmu_data so we can drop the
> > code allocating it. This also allows us to get rid of per-sensor back
> > reference to struct qoriq_tmu_data since now its address can be
> > caluclated using container_of().
>
> This seems to be a repeating pattern, drivers are forced to put a back
> pointer in the thermal sensor structure to regain access to the
> container structure in the get_temp callback.
>
> It would make sense to pass the sensor id to the get_temp callback as we
> register with the sensor id.
>

I'll rebase this series on the two patches you submitted.

> One comment below.
>
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> > Cc: Chris Healy <cphealy@...il.com>
> > Cc: Lucas Stach <l.stach@...gutronix.de>
> > Cc: Zhang Rui <rui.zhang@...el.com>
> > Cc: Eduardo Valentin <edubezval@...il.com>
> > Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> > Cc: Angus Ainslie (Purism) <angus@...ea.ca>
> > Cc: linux-imx@....com
> > Cc: linux-pm@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > ---
> >  drivers/thermal/qoriq_thermal.c | 20 ++++++++------------
> >  1 file changed, 8 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
> > index e281bdcfa11f..deb5cb6a0baf 100644
> > --- a/drivers/thermal/qoriq_thermal.c
> > +++ b/drivers/thermal/qoriq_thermal.c
> > @@ -59,22 +59,24 @@ struct qoriq_tmu_regs {
> >       u32 ttr3cr;             /* Temperature Range 3 Control Register */
> >  };
> >
> > -struct qoriq_tmu_data;
> > -
> >  /*
> >   * Thermal zone data
> >   */
> >  struct qoriq_sensor {
> > -     struct qoriq_tmu_data           *qdata;
> >       int                             id;
> >  };>
> >  struct qoriq_tmu_data {
> >       struct qoriq_tmu_regs __iomem *regs;
> >       bool little_endian;
>
> Why not replace the little_endian boolean by a couple of callback
> read/write and assign them to ioread32|ioread32be at init time.
>
> That will kill the tmu_read and tmu_write functions and from there you
> can figure out how to remove the qdata backpointer. In addition, it will
> save a few instructions to test the boolean.
>

I am sure you've seen it by now, but little_endian is going away in
this series in regmap conversion patch.

Thanks
Andrey Smirnov