linux-kernel - Re: [PATCH kselftest-next] selftests: cgroup: fix cleanup path in test_memcg_subtree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190408214628.GA14748@castle>
Date:   Mon, 8 Apr 2019 21:46:33 +0000
From:   Roman Gushchin <guro@...com>
To:     shuah <shuah@...nel.org>
CC:     Roman Gushchin <guroan@...il.com>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>
Subject: Re: [PATCH kselftest-next] selftests: cgroup: fix cleanup path in
 test_memcg_subtree_control()

On Mon, Apr 08, 2019 at 12:53:39PM -0600, shuah wrote:
> On 3/27/19 8:56 PM, Roman Gushchin wrote:
> > Dan reported, that cleanup path in test_memcg_subtree_control()
> > triggers a static checker warning:
> >    ./tools/testing/selftests/cgroup/test_memcontrol.c:76 \
> >    test_memcg_subtree_control()
> >    error: uninitialized symbol 'child2'.
> > 
> > Fix this by initializing child2 and parent2 variables and
> > split the cleanup path into few stages.
> > 
> > Signed-off-by: Roman Gushchin <guro@...com>
> > Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests")
> > Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> > Cc: Dan Carpenter <dan.carpenter@...cle.com>
> > Cc: Shuah Khan (Samsung OSG) <shuah@...nel.org>
> > Cc: Mike Rapoport <rppt@...ux.vnet.ibm.com>
> 
> 
> From and Signed-off don't match. Please fix it and resend the patch.

Done.

Thank you!

Roman