linux-kernel - Re: [PATCH kselftest-next] selftests: cgroup: fix cleanup path in test_memcg_subtree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Apr 2019 12:53:39 -0600
From:   shuah <shuah@...nel.org>
To:     Roman Gushchin <guroan@...il.com>, linux-kselftest@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Roman Gushchin <guro@...com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        shuah <shuah@...nel.org>
Subject: Re: [PATCH kselftest-next] selftests: cgroup: fix cleanup path in
 test_memcg_subtree_control()

On 3/27/19 8:56 PM, Roman Gushchin wrote:
> Dan reported, that cleanup path in test_memcg_subtree_control()
> triggers a static checker warning:
>    ./tools/testing/selftests/cgroup/test_memcontrol.c:76 \
>    test_memcg_subtree_control()
>    error: uninitialized symbol 'child2'.
> 
> Fix this by initializing child2 and parent2 variables and
> split the cleanup path into few stages.
> 
> Signed-off-by: Roman Gushchin <guro@...com>
> Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Cc: Dan Carpenter <dan.carpenter@...cle.com>
> Cc: Shuah Khan (Samsung OSG) <shuah@...nel.org>
> Cc: Mike Rapoport <rppt@...ux.vnet.ibm.com>


 From and Signed-off don't match. Please fix it and resend the patch.

thanks,
-- Shuah