linux-kernel - Re: [RESENT PATCH] mm/memory_hotplug: Do not unlock when fails to take the device_hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <209a8820-7f4f-c36c-2f48-ebfc31e64428@redhat.com>
Date:   Mon, 8 Apr 2019 09:05:53 +0200
From:   David Hildenbrand <david@...hat.com>
To:     zhong jiang <zhongjiang@...wei.com>, akpm@...ux-foundation.org,
        rafael@...nel.org, rafael.j.wysocki@...el.com, mhocko@...e.com,
        osalvador@...e.de
Cc:     vbabka@...e.cz, iamjoonsoo.kim@....com, bsingharora@...il.com,
        gregkh@...uxfoundation.org, yangyingliang@...wei.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [RESENT PATCH] mm/memory_hotplug: Do not unlock when fails to
 take the device_hotplug_lock

On 08.04.19 06:07, zhong jiang wrote:
> When adding the memory by probing memory block in sysfs interface, there is an
> obvious issue that we will unlock the device_hotplug_lock when fails to takes it.
> 
> That issue was introduced in Commit 8df1d0e4a265
> ("mm/memory_hotplug: make add_memory() take the device_hotplug_lock")
> 
> We should drop out in time when fails to take the device_hotplug_lock.
> 
> Fixes: 8df1d0e4a265 ("mm/memory_hotplug: make add_memory() take the device_hotplug_lock")
> Reported-by: Yang yingliang <yangyingliang@...wei.com>
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/base/memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index d9ebb89..0c9e22f 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -507,7 +507,7 @@ static ssize_t probe_store(struct device *dev, struct device_attribute *attr,
>  
>  	ret = lock_device_hotplug_sysfs();
>  	if (ret)
> -		goto out;
> +		return ret;
>  
>  	nid = memory_add_physaddr_to_nid(phys_addr);
>  	ret = __add_memory(nid, phys_addr,
> 

Indeed

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 

Thanks,

David / dhildenb