linux-kernel - Re: [RESENT PATCH] mm/memory_hotplug: Do not unlock when fails to take the device_hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190408072723.vbwtc5mruvx3un35@d104.suse.de>
Date:   Mon, 8 Apr 2019 09:27:31 +0200
From:   Oscar Salvador <osalvador@...e.de>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     akpm@...ux-foundation.org, rafael@...nel.org, david@...hat.com,
        rafael.j.wysocki@...el.com, mhocko@...e.com, vbabka@...e.cz,
        iamjoonsoo.kim@....com, bsingharora@...il.com,
        gregkh@...uxfoundation.org, yangyingliang@...wei.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [RESENT PATCH] mm/memory_hotplug: Do not unlock when fails to
 take the device_hotplug_lock

On Mon, Apr 08, 2019 at 12:07:17PM +0800, zhong jiang wrote:
> When adding the memory by probing memory block in sysfs interface, there is an
> obvious issue that we will unlock the device_hotplug_lock when fails to takes it.
> 
> That issue was introduced in Commit 8df1d0e4a265
> ("mm/memory_hotplug: make add_memory() take the device_hotplug_lock")
> 
> We should drop out in time when fails to take the device_hotplug_lock.
> 
> Fixes: 8df1d0e4a265 ("mm/memory_hotplug: make add_memory() take the device_hotplug_lock")
> Reported-by: Yang yingliang <yangyingliang@...wei.com>
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>

Reviewed-by: Oscar Salvador <osalvador@...e.de>

-- 
Oscar Salvador
SUSE L3