linux-kernel - Re: [PATCH v4 2/2] media:st-mipid02: MIPID02 CSI-2 to PARALLEL bridge driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190408091709.z27wmi47reu6zmuu@kekkonen.localdomain>
Date:   Mon, 8 Apr 2019 12:17:09 +0300
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Mickael GUENE <mickael.guene@...com>
Cc:     "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        Hugues FRUCHET <hugues.fruchet@...com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Matt Ranostay <matt.ranostay@...sulko.com>,
        Akinobu Mita <akinobu.mita@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hans Verkuil <hverkuil@...all.nl>,
        Ricardo Ribalda Delgado <ricardo@...alda.com>,
        Jason Chen <jasonx.z.chen@...el.com>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        Tianshu Qiu <tian.shu.qiu@...el.com>,
        Bingbu Cao <bingbu.cao@...el.com>,
        Alan Chiang <alanx.chiang@...el.com>
Subject: Re: [PATCH v4 2/2] media:st-mipid02: MIPID02 CSI-2 to PARALLEL
 bridge driver

Hi Mickael,

On Mon, Apr 08, 2019 at 08:20:09AM +0000, Mickael GUENE wrote:
...
> > The above are just minor improvements and cleanups. If you're fine with the
> > proposed change to the first patch, I can merge this version of the patches
> > and you could submit changes to the above in a separate patch.
> > 
> Thanks for the proposal, but I prefer to to a full v5 if you agree ?

That is fine, too.

> I will also add MEDIA_BUS_FMT_BGR888_3X8 or MEDIA_BUS_FMT_BGR888_3X8_BE
> support.

Ack. Please add a separate patch for that.

I guess postfix isn't needed as changing the endianness just changes the
pixel order in this case.

> >> +	.remove   = mipid02_remove,
> >> +};
> >> +
> >> +module_i2c_driver(mipid02_i2c_driver);
> >> +
> >> +MODULE_AUTHOR("Mickael Guene <mickael.guene@...com>");
> >> +MODULE_DESCRIPTION("STMicroelectronics MIPID02 CSI-2 bridge driver");
> >> +MODULE_LICENSE("GPL v2");

-- 
Sakari Ailus
sakari.ailus@...ux.intel.com