linux-kernel - RE: [PATCH] reset: axs10x: Implement assert and deassert callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Apr 2019 11:23:31 +0000
From:   Jose Abreu <jose.abreu@...opsys.com>
To:     Vitor Soares <vitor.soares@...opsys.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Eugeniy Paltsev <eugeniy.paltsev@...opsys.com>,
        Alexey Brodkin <alexey.brodkin@...opsys.com>,
        Joao Pinto <joao.pinto@...opsys.com>,
        Jose Abreu <jose.abreu@...opsys.com>,
        Luis de Oliveira <luis.oliveira@...opsys.com>,
        "Gustavo Pimentel" <gustavo.pimentel@...opsys.com>,
        Nelson Costa <nelson.costa@...opsys.com>,
        Pedro Sousa <pedrom.sousa@...opsys.com>,
        Philipp Zabel <p.zabel@...gutronix.de>
Subject: RE: [PATCH] reset: axs10x: Implement assert and deassert callbacks

From: Vitor Soares <vitor.soares@...opsys.com>
Date: Mon, Apr 08, 2019 at 11:31:23

>  static const struct reset_control_ops axs10x_reset_ops = {
> -	.reset	= axs10x_reset_reset,

Eugeniy, Alexey,

I think the implementation of this callback is wrong: you should
readl_poll_timeout_atomic() until the reset bit is not cleared.

Thanks,
Jose Miguel Abreu