linux-kernel - Re: [PATCH 19/27] x86/fpu: Update xstate's PKRU value on write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a824d713-a9b1-fa84-4826-be8d980d71e4@intel.com>
Date:   Mon, 8 Apr 2019 11:14:28 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        linux-kernel@...r.kernel.org
Cc:     x86@...nel.org, Andy Lutomirski <luto@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        kvm@...r.kernel.org, "Jason A. Donenfeld" <Jason@...c4.com>,
        Rik van Riel <riel@...riel.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>
Subject: Re: [PATCH 19/27] x86/fpu: Update xstate's PKRU value on write_pkru()

On 4/3/19 9:41 AM, Sebastian Andrzej Siewior wrote:
> During the context switch the xstate is loaded which also includes the
> PKRU value.
> If xstate is restored on return to userland it is required that the
> PKRU value in xstate is the same as the one in the CPU.

All of the protection keys bits in here look ok to me.  Thanks for the
sustained work to get all those into shape.  I know it's a special
snowflake.

Although I paid much closer attention to the PK bits, feel free to add:

Reviewed-by: Dave Hansen <dave.hansen@...el.com>

for the series.