linux-kernel - RE: [PATCH 3/3] phy: renesas: rcar-gen3-usb2: enable/disable independent irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TYAPR01MB4271AFFCCC0B2D1215227746D82D0@TYAPR01MB4271.jpnprd01.prod.outlook.com>
Date:   Tue, 9 Apr 2019 09:49:42 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Fabrizio Castro <fabrizio.castro@...renesas.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "kishon@...com" <kishon@...com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>
Subject: RE: [PATCH 3/3] phy: renesas: rcar-gen3-usb2: enable/disable
 independent irqs

Hello Fabrizio-san,

> From: Fabrizio Castro, Sent: Wednesday, April 3, 2019 7:49 PM
> 
> Hello Yoshihiro-san,
> 
> Thank you for your partch!
> 
> > From: devicetree-owner@...r.kernel.org <devicetree-owner@...r.kernel.org> On Behalf Of Yoshihiro Shimoda
> > Sent: 01 April 2019 13:01
> > Subject: [PATCH 3/3] phy: renesas: rcar-gen3-usb2: enable/disable independent irqs
> >
> > Since the previous code enabled/disabled the irqs both OHCI and EHCI,
> > it is possible to cause unexpected interruptions. To avoid this,
> > this patch creates multiple phy instances from phandle and
> > enables/disables independent irqs by the instances.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> 
> Reviewed-by: Fabrizio Castro <fabrizio.castro@...renesas.com>
> Tested-by: Fabrizio Castro <fabrizio.castro@...renesas.com>

Thank you for your review and test!

<snip>
> > +static enum usb_dr_mode rcar_gen3_get_dr_mode(struct device_node *np)
> > +{
> > +	enum usb_dr_mode candidate = USB_DR_MODE_UNKNOWN, tmp;
> > +	int i;
> > +
> > +	/*
> > +	 * If one of device nodes has other dr_mode except UNKNOWN,
> > +	 * this function returns UNKNOWN.
> > +	 */
> > +	for (i = 0; i < NUM_OF_PHYS; i++) {
> > +		tmp = of_usb_get_dr_mode_by_phy(np, i);
> 
> We are calling of_usb_get_dr_mode_by_phy with i == 0, but we don't document it
> in the dt-bindings document?

This (i == 0) is for backward compatibility. So, I'll add such a comment on the driver.

Best regards,
Yoshihiro Shimoda