lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190409020553.GA7228@ranerica-svr.sc.intel.com> Date: Mon, 8 Apr 2019 19:05:53 -0700 From: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com> To: Thomas Gleixner <tglx@...utronix.de> Cc: Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...e.de>, Ashok Raj <ashok.raj@...el.com>, Andi Kleen <andi.kleen@...el.com>, Peter Zijlstra <peterz@...radead.org>, "Ravi V. Shankar" <ravi.v.shankar@...el.com>, x86@...nel.org, linux-kernel@...r.kernel.org, Ricardo Neri <ricardo.neri@...el.com>, "H. Peter Anvin" <hpa@...or.com>, Tony Luck <tony.luck@...el.com>, "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, Don Zickus <dzickus@...hat.com>, Nicholas Piggin <npiggin@...il.com>, Michael Ellerman <mpe@...erman.id.au>, Frederic Weisbecker <frederic@...nel.org>, Alexei Starovoitov <ast@...nel.org>, Babu Moger <babu.moger@...cle.com>, Paul Mackerras <paulus@...ba.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Masami Hiramatsu <mhiramat@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, Philippe Ombredanne <pombredanne@...b.com>, Colin Ian King <colin.king@...onical.com>, Byungchul Park <byungchul.park@....com>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, "Luis R. Rodriguez" <mcgrof@...nel.org>, Waiman Long <longman@...hat.com>, Josh Poimboeuf <jpoimboe@...hat.com>, Randy Dunlap <rdunlap@...radead.org>, Davidlohr Bueso <dave@...olabs.net>, Christoffer Dall <cdall@...aro.org>, Marc Zyngier <marc.zyngier@....com>, Kai-Heng Feng <kai.heng.feng@...onical.com>, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>, David Rientjes <rientjes@...gle.com>, "David S. Miller" <davem@...emloft.net>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, sparclinux@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org Subject: Re: [RFC PATCH v2 10/14] kernel/watchdog: Add a function to obtain the watchdog_allowed_mask On Tue, Mar 26, 2019 at 10:22:40PM +0100, Thomas Gleixner wrote: > On Wed, 27 Feb 2019, Ricardo Neri wrote: > > > > -struct cpumask watchdog_allowed_mask __read_mostly; > > +static struct cpumask watchdog_allowed_mask __read_mostly; > > That hunk is correct. I'll send a separate patch with this hunk only. > > > struct cpumask watchdog_cpumask __read_mostly; > > unsigned long *watchdog_cpumask_bits = cpumask_bits(&watchdog_cpumask); > > @@ -92,6 +92,11 @@ static int __init hardlockup_all_cpu_backtrace_setup(char *str) > > } > > __setup("hardlockup_all_cpu_backtrace=", hardlockup_all_cpu_backtrace_setup); > > # endif /* CONFIG_SMP */ > > + > > +struct cpumask *watchdog_get_allowed_cpumask(void) > > +{ > > + return &watchdog_allowed_mask; > > +} > > That part is pointless as I showed you in the other reply. You don't need > that mask in your code at all. Yes. I'll remove this hunk and follow the approach you suggested in your reply to patch 11. Thanks and BR, Ricardo > > Thanks, > > tglx > >
Powered by blists - more mailing lists