linux-kernel - Re: per-device dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 09 Apr 2019 17:03:52 +0300
From:   David Woodhouse <dwmw2@...radead.org>
To:     Christoph Hellwig <hch@....de>, Joerg Roedel <joro@...tes.org>
Cc:     iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: per-device dma_map_ops for intel-iommu?

On Tue, 2019-04-09 at 15:59 +0200, Christoph Hellwig wrote:
> Hi David and Joerg,
> 
> do you remember a good reason why intel-iommu is not using per-device
> dma_map_ops like the AMD iommu or the various ARM iommus?
> 
> Right now intel-iommu.c contains a half-asses reimplementation of the
> dma direct code for the iommu_no_mapping() case, and it would seem
> much nicer to just fall back to that case and not even call into
> intel-iommu in that case.

Other than the complexities about passthrough mode and various "oh shit
we forgot to actually test that iommu+gfx actually works before
shipping hardware" type of quirks that bypass the IOMMU for certain
devices — and retpolines, which I think you already dealt with — no, no
good reason that I recall.

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5174 bytes)