lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 9 Apr 2019 19:23:09 +0200 From: Christoph Hellwig <hch@....de> To: Robin Murphy <robin.murphy@....com> Cc: Christoph Hellwig <hch@....de>, Joerg Roedel <joro@...tes.org>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, Tom Lendacky <thomas.lendacky@....com>, iommu@...ts.linux-foundation.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 07/21] dma-iommu: move the arm64 wrappers to common code On Tue, Apr 09, 2019 at 04:07:02PM +0100, Robin Murphy wrote: >> -static inline int iommu_dma_init(void) >> +static inline void iommu_setup_dma_ops(struct device *dev, u64 dma_base, >> + u64 size, const struct iommu_ops *ops) >> { >> - return 0; >> } > > I don't think it makes sense to have a stub for that - AFAICS it should > only ever be called form arch code with an inherent "select IOMMU_DMA" > (much like the stuff which isn't stubbed currently). > > Otherwise, I'm about 97% sure the rest of the move looks OK - thanks for > splitting things up. arm64 only selects IOMMU_DMA if IOMMU_SUPPORT is selected, which can be disabled. So to keep some (unusual) arm64 configs compiling we'll need the stub..
Powered by blists - more mailing lists