linux-kernel - Re: [PATCH] drm/bochs: use simple display pipe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190410212240.GA31691@ravnborg.org>
Date:   Wed, 10 Apr 2019 23:22:40 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Gerd Hoffmann <kraxel@...hat.com>
Cc:     dri-devel@...ts.freedesktop.org, David Airlie <airlied@...ux.ie>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:DRM DRIVER FOR BOCHS VIRTUAL GPU" 
        <virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH] drm/bochs: use simple display pipe

Hi Gerd.

>  
>  #include <drm/drm_gem.h>
>  
> @@ -69,9 +70,8 @@ struct bochs_device {
>  	struct edid *edid;
>  
>  	/* drm */
> -	struct drm_device  *dev;
> -	struct drm_crtc crtc;
> -	struct drm_encoder encoder;
> +	struct drm_device *dev;
> +	struct drm_simple_display_pipe pipe;
>  	struct drm_connector connector;

Have you considered to embed drm_device in the bochs_device struct?
This is the new way to do it.

This should likely be a follow-up patch...

Rest of the patch looked good.
Did not do a proper review but you can add my:
Acked-by: Sam Ravnborg <sam@...nborg.org>

	Sam