linux-kernel - Re: [PATCH] lib/Kconfig.debug: Fix build error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jLmbiLZmLtFKpEJAB_VFpaOjDMhWk=Z_sD1iegM2kpSYw@mail.gmail.com>
Date:   Wed, 10 Apr 2019 10:30:55 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Petr Mladek <pmladek@...e.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Matthew Wilcox <willy@...radead.org>,
        Joe Lawrence <joe.lawrence@...hat.com>, dunlap@...radead.org,
        Robin Murphy <robin.murphy@....com>,
        "Luis R. Rodriguez" <mcgrof@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lib/Kconfig.debug: Fix build error without CONFIG_BLOCK

On Wed, Apr 10, 2019 at 12:55 AM Yue Haibing <yuehaibing@...wei.com> wrote:
>
> From: YueHaibing <yuehaibing@...wei.com>
>
> If CONFIG_TEST_KMOD is set to M, while CONFIG_BLOCK is not set,
> XFS and BTRFS can not be compiled successly.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  lib/Kconfig.debug | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 2020d76..65ad61b 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1939,6 +1939,7 @@ config TEST_KMOD
>         tristate "kmod stress tester"
>         depends on m
>         depends on NETDEVICES && NET_CORE && INET # for TUN
> +       depends on BLOCK
>         select TEST_LKM
>         select XFS_FS
>         select TUN

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook