lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <df1f3722-28a1-30eb-7dbf-e4d4586c9bc3@samsung.com> Date: Fri, 12 Apr 2019 09:59:21 +0900 From: Chanwoo Choi <cw00.choi@...sung.com> To: myungjoo.ham@...sung.com, wens@...e.org, hdegoede@...hat.com, rjw@...ysocki.net, "stable@...r.kernel.org" <stable@...r.kernel.org> Cc: linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org Subject: Re: [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry Dear all, + stable@...r.kernel.org It should be posted to stable@...r.kernel.org in order to merge it to stable tree. Regards, Chanwoo Choi On 19. 4. 12. 오전 8:30, Chanwoo Choi wrote: > On 19. 4. 4. 오후 11:17, Yue Haibing wrote: >> From: YueHaibing <yuehaibing@...wei.com> >> >> As Hans de Goede pointed, using this driver without ACPI >> makes little sense, so add ACPI dependency to Kconfig entry >> to fix a build error while CONFIG_ACPI is not set. >> >> drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe': >> drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to incomplete type >> put_device(&adev->dev); >> >> Fixes: 0cf064db948a ("extcon: axp288: Convert to use acpi_dev_get_first_match_dev()") >> Reported-by: Hulk Robot <hulkci@...wei.com> >> Suggested-by: Hans de Goede <hdegoede@...hat.com> >> Signed-off-by: YueHaibing <yuehaibing@...wei.com> >> --- >> v2: rework patch >> --- >> drivers/extcon/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig >> index 1ed4b45..de06faf 100644 >> --- a/drivers/extcon/Kconfig >> +++ b/drivers/extcon/Kconfig >> @@ -30,7 +30,7 @@ config EXTCON_ARIZONA >> >> config EXTCON_AXP288 >> tristate "X-Power AXP288 EXTCON support" >> - depends on MFD_AXP20X && USB_SUPPORT && X86 >> + depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI >> select USB_ROLE_SWITCH >> help >> Say Y here to enable support for USB peripheral detection >> > > Applied it. Thanks. > -- Best Regards, Chanwoo Choi Samsung Electronics
Powered by blists - more mailing lists