lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 12 Apr 2019 07:35:05 +0000
From:   Jose Abreu <>
To:     "Leonidas P. Papadakos" <>,
        Robin Murphy <>
CC:     Jose Abreu <>,
        Philipp Tomsich <>,
        Heiko Stübner <>,
        Christoph Müllner 
        Maxime Coquelin <>,
        Alexandre Torgue <>,
        "" <>,
        LKML <>,
        Linux ARM <>,
        Klaus Goger <>
Subject: RE: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX
 offload for rockchip devices

From: Leonidas P. Papadakos <>
Date: Thu, Apr 11, 2019 at 22:09:30

> At this point I've settled on snps,txpbl = <0x20> by itself.
> If I increase the MTU from the default of 1500 I get a stack trace and 
> link reset almost immediately:
> (
> whether TX Checksumming is ON or OFF.

Can you please share the stacktrace here ? I can't access pastebin due to 
corporate policy.

If it's a queue timeout then please share your "dmesg | grep -i stmmac" 
since boot.

> That said, with the default MTU, I get better speeds when TX 
> Checksumming is on and the PBL tweak is set.
> Is there a better option in the horizon for the near future?
> At least for the Renegade (the only board I have to test) it can serve 
> as a temporary workaround.
> Should I make a patch to replace force_thresh_dma_mode with txbpl 
> <0x20> for the Renegade specifically?
> In any case I would be happy to help as much as I can to figure out if 
> it's a board specific thing, or SoC, or even an issue of the Ethernet 
> device itself.

This is not a workaround neither an issue. It's well stablished that PBL 
setting interferes with COE so one must choose a setting that depends on 
FIFO size. I would like to make it automatic in the driver but I didn't 
have the time to submit a patch yet, sorry.

Jose Miguel Abreu

Powered by blists - more mailing lists