linux-kernel - Re: [PATCH 4/5] lib/test_bitmap: add testcases for bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190412084029.GI9224@smile.fi.intel.com>
Date:   Fri, 12 Apr 2019 11:40:29 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Yury Norov <yury.norov@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Arnd Bergmann <arnd@...db.de>,
        Kees Cook <keescook@...omium.org>,
        Matthew Wilcox <willy@...radead.org>,
        Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
        Mike Travis <travis@....com>, Yury Norov <ynorov@...vell.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] lib/test_bitmap: add testcases for bitmap_parselist

On Thu, Apr 11, 2019 at 11:39:46AM -0700, Guenter Roeck wrote:
> On Fri, Apr 05, 2019 at 08:32:10PM +0300, Yury Norov wrote:
> > Add tests for non-number character, empty regions, integer overflow.

> >  	{0, "1-31:4/4",			&exp[9 * step], 32, 0},
> >  	{0, "0-31:1/4,32-63:2/4",	&exp[10 * step], 64, 0},
> >  	{0, "0-31:3/4,32-63:4/4",	&exp[11 * step], 64, 0},
> > +	{0, "  ,,  0-31:3/4  ,, 32-63:4/4  ,,  ",	&exp[11 * step], 64, 0},
> >  
> >  	{0, "0-31:1/4,32-63:2/4,64-95:3/4,96-127:4/4",	exp2, 128, 0},
> >  
> >  	{0, "0-2047:128/256", NULL, 2048, PARSE_TIME},
> >  
> > +	{0, "",				&exp[12], 8, 0},
> > +	{0, "\n",			&exp[12], 8, 0},
> > +	{0, ",,  ,,  , ,  ,",		&exp[12], 8, 0},
> > +	{0, " ,  ,,  , ,   ",		&exp[12], 8, 0},
> > +	{0, " ,  ,,  , ,   \n",		&exp[12], 8, 0},
> > +
> 
> This results in error messages such as
> 
> test_bitmap: parselist: 17: input is ,, ,,  , ,  ,, result is 0x0, expected 0x11111111
> test_bitmap: parselist: 18: input is  ,  ,,  , ,   , result is 0x0, expected 0x11111111
> 
> on 32-bit systems. The above should be "&exp[12 * step]".

Nice catch!

-- 
With Best Regards,
Andy Shevchenko