linux-kernel - Re: [PATCH 3/5] pinctrl: st: fix leaked of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Apr 2019 08:57:03 +0000
From:   Patrice CHOTARD <patrice.chotard@...com>
To:     Wen Yang <wen.yang99@....com.cn>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "wang.yi59@....com.cn" <wang.yi59@....com.cn>,
        Linus Walleij <linus.walleij@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 3/5] pinctrl: st: fix leaked of_node references

Hi Wen

On 4/12/19 8:02 AM, Wen Yang wrote:
> The call to of_get_child_by_name returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
> 
> Detected by coccinelle with the following warnings:
> ./drivers/pinctrl/pinctrl-st.c:1188:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1175, but without a corresponding object release within this function.
> ./drivers/pinctrl/pinctrl-st.c:1188:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1175, but without a corresponding object release within this function.
> ./drivers/pinctrl/pinctrl-st.c:1199:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1175, but without a corresponding object release within this function.
> ./drivers/pinctrl/pinctrl-st.c:1199:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1175, but without a corresponding object release within this function.
> 
> Signed-off-by: Wen Yang <wen.yang99@....com.cn>
> Cc: Patrice Chotard <patrice.chotard@...com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: linux-gpio@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org (open list)
> ---
>  drivers/pinctrl/pinctrl-st.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index e66af93..195b442 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1170,7 +1170,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
>  	struct property *pp;
>  	struct st_pinconf *conf;
>  	struct device_node *pins;
> -	int i = 0, npins = 0, nr_props;
> +	int i = 0, npins = 0, nr_props, ret = 0;
>  
>  	pins = of_get_child_by_name(np, "st,pins");
>  	if (!pins)
> @@ -1185,7 +1185,8 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
>  			npins++;
>  		} else {
>  			pr_warn("Invalid st,pins in %pOFn node\n", np);
> -			return -EINVAL;
> +			ret = -EINVAL;
> +			goto out_put_node;
>  		}
>  	}
>  
> @@ -1195,8 +1196,10 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
>  	grp->pin_conf = devm_kcalloc(info->dev,
>  					npins, sizeof(*conf), GFP_KERNEL);
>  
> -	if (!grp->pins || !grp->pin_conf)
> -		return -ENOMEM;
> +	if (!grp->pins || !grp->pin_conf) {
> +		ret = -ENOMEM;
> +		goto out_put_node;
> +	}
>  
>  	/* <bank offset mux direction rt_type rt_delay rt_clk> */
>  	for_each_property_of_node(pins, pp) {
> @@ -1229,9 +1232,11 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
>  		}
>  		i++;
>  	}
> +
> +out_put_node:
>  	of_node_put(pins);
>  
> -	return 0;
> +	return ret;
>  }
>  
>  static int st_pctl_parse_functions(struct device_node *np,
> 

Reviewed-by: Patrice Chotard <patrice.chotard@...com>

Thanks