linux-kernel - Re: [PATCH 1/5] pinctrl: pistachio: fix leaked of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2957471-b2b2-0266-61d1-03bc4a643fb7@web.de>
Date:   Sun, 14 Apr 2019 15:15:57 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Wen Yang <wen.yang99@....com.cn>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Yi Wang <wang.yi59@....com.cn>
Subject: Re: [PATCH 1/5] pinctrl: pistachio: fix leaked of_node references

> @@ -1367,6 +1367,7 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl)
>  		if (!of_find_property(child, "gpio-controller", NULL)) {
>  			dev_err(pctl->dev,
>  				"No gpio-controller property for bank %u\n", i);
> +			of_node_put(child);
>  			ret = -ENODEV;
>  			goto err;
>  		}
> @@ -1374,6 +1375,7 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl)
>  		irq = irq_of_parse_and_map(child, 0);
>  		if (irq < 0) {
>  			dev_err(pctl->dev, "No IRQ for bank %u: %d\n", i, irq);
> +			of_node_put(child);
>  			ret = irq;
>  			goto err;
>  		}

Would you like to move such duplicate statements (and other function calls)
to additional jump targets for the desired exception handling?

Regards,
Markus