linux-kernel - Re: [PATCH v3 1/1] iommu: Bind process address spaces to devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa213d61-2351-73f4-629c-08a18320fbec@arm.com>
Date:   Fri, 12 Apr 2019 13:23:51 +0100
From:   Jean-Philippe Brucker <jean-philippe.brucker@....com>
To:     Joerg Roedel <joro@...tes.org>
Cc:     "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "christian.koenig@....com" <christian.koenig@....com>,
        "kevin.tian@...el.com" <kevin.tian@...el.com>,
        "jacob.jun.pan@...ux.intel.com" <jacob.jun.pan@...ux.intel.com>,
        "ashok.raj@...el.com" <ashok.raj@...el.com>,
        "baolu.lu@...ux.intel.com" <baolu.lu@...ux.intel.com>,
        "zhangfei.gao@...mail.com" <zhangfei.gao@...mail.com>
Subject: Re: [PATCH v3 1/1] iommu: Bind process address spaces to devices

On 11/04/2019 16:28, Joerg Roedel wrote:
> On Wed, Apr 10, 2019 at 04:15:16PM +0100, Jean-Philippe Brucker wrote:
>>  drivers/iommu/iommu.c | 104 ++++++++++++++++++++++++++++++++++++++++++
>>  include/linux/iommu.h |  70 ++++++++++++++++++++++++++++
>>  2 files changed, 174 insertions(+)
> 
> Applied to the api-features branch for now, thanks Jean-Philippe!
> 
> 'for now' because I have a question below.
> 
>> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
>> index ed6738c358ca..87fe1cddd817 100644
>> --- a/include/linux/iommu.h
>> +++ b/include/linux/iommu.h
>> @@ -51,10 +51,13 @@ struct device;
>>  struct iommu_domain;
>>  struct notifier_block;
>>  struct iommu_fault_event;
>> +struct iommu_sva;
> 
> The iommu_fault_event doesn't yet exist in my tree, is this patch based
> on something else I need besided Lu Baolus work? I got quite some
> conflicts while applying the patch because of this.

Ugh, sorry about this, I forgot to rebase onto master. The only required
patch is Lu Baolu's "iommu: Add APIs for multiple domains per device".
The iommu_fault_event is introduced by Jacob's fault reporting work, but
is independent from this patch.

There also is a small conflict with the SMMUv3 ATS work, which I'm
hoping to get in v5.2 as well (but will probably require more work).
I'll send next version of ATS applied on top of this patch.

I pushed a cleaner version to git://linux-arm.org/linux-jpb.git sva/api
(with the below mistake fixed as well) and can resend if necessary.

Thanks,
Jean

> 
>> + * @sva_set_ops: Set ops for a SVA handle
> 
> I also removed this line.
> 
> Regards,
> 
>         Joerg