lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Apr 2019 21:26:41 +0800 From: YueHaibing <yuehaibing@...wei.com> To: Andy Shevchenko <andy.shevchenko@...il.com>, "Rafael J. Wysocki" <rjw@...ysocki.net> CC: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <bgolaszewski@...libre.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, ACPI Devel Maling List <linux-acpi@...r.kernel.org> Subject: Re: [PATCH v2] gpio: merrifield: Fix build err without CONFIG_ACPI On 2019/4/12 21:13, Andy Shevchenko wrote: > On Fri, Apr 12, 2019 at 3:55 AM Rafael J. Wysocki <rjw@...ysocki.net> wrote: >> On Friday, April 5, 2019 4:50:09 PM CEST Andy Shevchenko wrote: >>> On Fri, Apr 05, 2019 at 10:21:12PM +0800, Yue Haibing wrote: >>>> From: YueHaibing <yuehaibing@...wei.com> >>>> >>>> When building CONFIG_ACPI is not set >>>> gcc warn this: >>>> >>>> drivers/gpio/gpio-merrifield.c: In function >>>> mrfld_gpio_get_pinctrl_dev_name: drivers/gpio/gpio-merrifield.c:388:19: >>>> error: dereferencing pointer to incomplete type struct acpi_device> >>>> put_device(&adev->dev); >>>> >>>> ^ >>>> >>>> Reported-by: Hulk Robot <hulkci@...wei.com> >>>> Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> >>>> Fixes:d00d2109c367 ("gpio: merrifield: Convert to use >>>> acpi_dev_get_first_match_dev()") Signed-off-by: YueHaibing >>>> <yuehaibing@...wei.com> >>> >>> Thank you for an update, I have a comment below, but before sending v3, let >>> Rafael to have a chance to look at it. >>> >>>> #ifdef CONFIG_ACPI >>>> extern int acpi_platform_notify(struct device *dev, enum kobject_action >>>> action);> >>>> + >>>> +static inline void put_acpi_device(struct acpi_device *adev) >>>> +{ >>>> + put_device(&adev->dev); >>>> +} >>> >>> This should probably go to acpi_bus.h under acpi_dev_get_first_match_dev(). >>> And talking to Mika we agreed that naming would be better as acpi_dev_put(). >> >> Agreed on both accounts. > > Thanks! > YueHaibing, please, send v3 with suggested changes. Ok. >
Powered by blists - more mailing lists