linux-kernel - Re: [PATCH] reset: axs10x: Implement assert and deassert callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1555075583.2668.20.camel@synopsys.com>
Date:   Fri, 12 Apr 2019 13:26:26 +0000
From:   Eugeniy Paltsev <eugeniy.paltsev@...opsys.com>
To:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jose Abreu <jose.abreu@...opsys.com>
CC:     Joao Pinto <joao.pinto@...opsys.com>,
        "nelson.costa@...opsys.com" <nelson.costa@...opsys.com>,
        Luis de Oliveira <luis.oliveira@...opsys.com>,
        "vitor.soares@...opsys.com" <vitor.soares@...opsys.com>,
        "eugeniy.Paltsev@...opsys.com" <eugeniy.paltsev@...opsys.com>,
        "gustavo.pimentel@...opsys.com" <gustavo.pimentel@...opsys.com>,
        "Alexey Brodkin" <alexey.brodkin@...opsys.com>,
        "jose.abreu@...opsys.com" <jose.abreu@...opsys.com>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "pedrom.sousa@...opsys.com" <pedrom.sousa@...opsys.com>
Subject: Re: [PATCH] reset: axs10x: Implement assert and deassert callbacks

Hi Jose,

On Mon, 2019-04-08 at 11:23 +0000, Jose Abreu wrote:
> From: Vitor Soares <vitor.soares@...opsys.com>
> Date: Mon, Apr 08, 2019 at 11:31:23
> 
> >  static const struct reset_control_ops axs10x_reset_ops = {
> > -	.reset	= axs10x_reset_reset,
> 
> Eugeniy, Alexey,
> 
> I think the implementation of this callback is wrong: you should
> readl_poll_timeout_atomic() until the reset bit is not cleared.

I don't remember if this register is read/write or write-only. I'll check it.
Thanks for report.

> 
> Thanks,
> Jose Miguel Abreu
-- 
 Eugeniy Paltsev