linux-kernel - RE: [PATCH] reset: axs10x: Implement assert and deassert callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13D59CF9CEBAF94592A12E8AE55501350A61459C@DE02WEMBXB.internal.synopsys.com>
Date:   Fri, 12 Apr 2019 14:42:29 +0000
From:   Vitor Soares <vitor.soares@...opsys.com>
To:     Eugeniy Paltsev <eugeniy.paltsev@...opsys.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "vitor.soares@...opsys.com" <vitor.soares@...opsys.com>
CC:     Joao Pinto <joao.pinto@...opsys.com>,
        "nelson.costa@...opsys.com" <nelson.costa@...opsys.com>,
        Luis de Oliveira <luis.oliveira@...opsys.com>,
        "eugeniy.Paltsev@...opsys.com" <eugeniy.paltsev@...opsys.com>,
        "gustavo.pimentel@...opsys.com" <gustavo.pimentel@...opsys.com>,
        "Alexey Brodkin" <alexey.brodkin@...opsys.com>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "jose.abreu@...opsys.com" <jose.abreu@...opsys.com>,
        "pedrom.sousa@...opsys.com" <pedrom.sousa@...opsys.com>
Subject: RE: [PATCH] reset: axs10x: Implement assert and deassert callbacks

Hi Eugeniy,

From: Eugeniy Paltsev <paltsev@...opsys.com>
Date: Fri, Apr 12, 2019 at 14:22:33

> Hi Vitor,
> 
> On Mon, 2019-04-08 at 13:25 +0000, Vitor Soares wrote:
> > Hi Eugeniy,
> > 
> > From: Eugeniy Paltsev <paltsev@...opsys.com>
> > Date: Mon, Apr 08, 2019 at 12:40:00
> > 
> > > Hi Vitor,
> > > 
> > > On Mon, 2019-04-08 at 12:31 +0200, Vitor Soares wrote:
> > > > Some custom IP-block connected to ARC AXS10x board need assert and
> > > > deassert functions to control reset signal of selected peripherals.
> > > > 
> > > > This patch improve AXS10x reset driver by adding assert and deassert
> > > > callbacks.
> > > 
> > > 
> > > In the AXS10x reset driver only 'reset' callback is intentionally 
> > > > implemented.
> > > 
> > > AXS10x is FPGA based boards and with our default firmware AXS10x reset 
> > > > register is implemented as self-deasserted.
> > 
> > I have another reset block connect through AXI.
> > 
> > > Do you have somehow modified AXS10x firmware where reset register is not 
> > > > self-deasserted?
> > > 
> > > In that case "simple-reset" driver will be suitable for you, I guess.
> > 
> > I will try it.
> > 
> > > Otherwise this implementation is incorrect - there should be no 'assert' for 
> > > > reset controller with self-deasserted logic.
> > 
> > So the assert and reset callback are mutually exclusive?
> 
> Not actually.
> 
> Adding 'assert' callback is incorrect for exclusive reset controls in
> case of self-deasserted reset controller.
> It will cause reset_control_assert() to return success for exclusive
> reset controls, even though the .assert op failed to leave the reset
> line asserted after the function returns.
> 

Sorry I'm not understanding. Can you please explain?

What I see in reset_control_assert() when not shared is return -ENOTSUPP.

> 
> [snap]
> > 
> > Best regards,
> > Vitor Soares
> > 
> -- 
>  Eugeniy Paltsev

Thanks for your feedback.


Best regards,
Vitor Soares