linux-kernel - Re: [PATCH v2 1/2] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190412134244.GC324@lunn.ch>
Date:   Fri, 12 Apr 2019 15:42:44 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     "Angus Ainslie (Purism)" <angus@...ea.ca>
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/2] arm64: dts: fsl: librem5: Add a device tree for
 the Librem5 devkit

> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethphy0: ethernet-phy@1 {
> +			compatible = "ethernet-phy-ieee802.3-c22";

Hi Angus

This compatible string is optional. It won't warm, but it is not
needed.

> +			reg = <1>;
> +			power-supply = <&reg_3V3_P>;

I don't remember seeing a power-supply property in an Ethernet PHY
node before. What is using it? The PHY driver? Or the driver core
code?

	Andrew