linux-kernel - Re: [PATCH V5 3/3] hwmon: pwm-fan: Add RPM support via external interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c9616343-baa0-8bda-9190-720bc08eda88@roeck-us.net>
Date:   Fri, 12 Apr 2019 07:29:04 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Robin Murphy <robin.murphy@....com>,
        Stefan Wahren <stefan.wahren@...e.com>
Cc:     Kamil Debski <kamil@...as.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Jean Delvare <jdelvare@...e.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V5 3/3] hwmon: pwm-fan: Add RPM support via external
 interrupt

On 4/12/19 6:54 AM, Robin Murphy wrote:
> On 12/04/2019 14:50, Guenter Roeck wrote:
>> On 4/12/19 4:50 AM, Robin Murphy wrote:
>>> On 12/04/2019 12:07, Stefan Wahren wrote:
>>>> On 11.04.19 18:57, Guenter Roeck wrote:
>>>>> On Thu, Apr 11, 2019 at 03:30:11PM +0200, Stefan Wahren wrote:
>>>>>> -ATTRIBUTE_GROUPS(pwm_fan);
>>>>>> +static umode_t pwm_fan_attrs_visible(struct kobject *kobj, struct attribute *a,
>>>>>> +                     int n)
>>>>>> +{
>>>>>> +    struct device *dev = container_of(kobj, struct device, kobj);
>>>>>> +    struct pwm_fan_ctx *ctx = dev_get_drvdata(dev);
>>>>>> +    struct device_attribute *devattr;
>>>>>> +
>>>>>> +    /* Hide fan_input in case no interrupt is available  */
>>>>>> +    devattr = container_of(a, struct device_attribute, attr);
>>>>> Field day for static analyzers - devattr is no longer used.
>>>>> No need to resend. I'll let the series rest for a couple of days
>>>>> and then apply to hwmon-next (after removing devattr) unless there are
>>>>> additional comments.
>>>>>
>>>> Thank you
>>>
>>> FWIW you can have a
>>>
>>> Reviewed-by: Robin Murphy <robin.murphy@....com>
>>>
>>> for the whole series. The only minor comment that springs to mind
>>> isn't actually specific to this patch, so is probably best made as
>>> the follow-up below.
>>>
>>> Robin.
>>>
>>
>> Any chance you can send the patch below as separate patch ? I track patches
>> using patchwork, and attachments don't show up there.
> 
> Sure, can do - would you like an explicit R-b on #1 and #2 here for patchwork to pick up as well?
> That would simplify my life a bit, but I can add that part myself to the patches.
I primarily like to have the patches in patchwork to make sure they don't get lost
and that I can pick them up again later if needed.

Thanks,
Guenter

> Robin.
> 
>>
>> Thanks,
>> Guenter
>>
>>> ----->8-----
>>> From: Robin Murphy <robin.murphy@....com>
>>> Subject: [PATCH] hwmon: pwm-fan: Report probe errors consistently
>>>
>>> Printing the error code for a failure provides a head-start for
>>> debugging, since it's often sufficient to pinpoint the origin of the
>>> failure. We already do this for some probe-failure messages, so let's
>>> make the rest of them consistent.
>>>
>>> Signed-off-by: Robin Murphy <robin.murphy@....com>
>>> ---
>>>   drivers/hwmon/pwm-fan.c | 13 ++++++++-----
>>>   1 file changed, 8 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
>>> index 8c4c5eefd4ca..556db4bef743 100644
>>> --- a/drivers/hwmon/pwm-fan.c
>>> +++ b/drivers/hwmon/pwm-fan.c
>>> @@ -330,7 +330,7 @@ static int pwm_fan_probe(struct platform_device *pdev)
>>>
>>>       ret = pwm_apply_state(ctx->pwm, &state);
>>>       if (ret) {
>>> -        dev_err(&pdev->dev, "Failed to configure PWM\n");
>>> +        dev_err(&pdev->dev, "Failed to configure PWM: %d\n", ret);
>>>           goto err_reg_disable;
>>>       }
>>>
>>> @@ -348,7 +348,8 @@ static int pwm_fan_probe(struct platform_device *pdev)
>>>           ret = devm_request_irq(&pdev->dev, ctx->irq, pulse_handler, 0,
>>>                          pdev->name, ctx);
>>>           if (ret) {
>>> -            dev_err(&pdev->dev, "Can't get interrupt working.\n");
>>> +            dev_err(&pdev->dev,
>>> +                "Failed to request interrupt: %d\n", ret);
>>>               goto err_pwm_disable;
>>>           }
>>>           ctx->sample_start = ktime_get();
>>> @@ -358,8 +359,9 @@ static int pwm_fan_probe(struct platform_device *pdev)
>>>       hwmon = devm_hwmon_device_register_with_groups(&pdev->dev, "pwmfan",
>>>                                  ctx, pwm_fan_groups);
>>>       if (IS_ERR(hwmon)) {
>>> -        dev_err(&pdev->dev, "Failed to register hwmon device\n");
>>>           ret = PTR_ERR(hwmon);
>>> +        dev_err(&pdev->dev,
>>> +            "Failed to register hwmon device: %d\n", ret);
>>>           goto err_del_timer;
>>>       }
>>>
>>> @@ -373,9 +375,10 @@ static int pwm_fan_probe(struct platform_device *pdev)
>>>                                 "pwm-fan", ctx,
>>>                                 &pwm_fan_cooling_ops);
>>>           if (IS_ERR(cdev)) {
>>> -            dev_err(&pdev->dev,
>>> -                "Failed to register pwm-fan as cooling device");
>>>               ret = PTR_ERR(cdev);
>>> +            dev_err(&pdev->dev,
>>> +                "Failed to register pwm-fan as cooling device: %d\n",
>>> +                ret);
>>>               goto err_del_timer;
>>>           }
>>>           ctx->cdev = cdev;
>>>
>>
>