linux-kernel - Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190412154051.GW2839@atomide.com>
Date:   Fri, 12 Apr 2019 08:40:51 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Ladislav Michl <ladis@...ux-mips.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, YueHaibing <yuehaibing@...wei.com>,
        Keerthy <j-keerthy@...com>
Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove
 omap_dm_timer_set_load_start

* Nathan Chancellor <natechancellor@...il.com> [190412 05:00]:
> On Thu, Apr 11, 2019 at 01:56:57PM -0700, Tony Lindgren wrote:
> > Hi,
> > 
> > * Daniel Lezcano <daniel.lezcano@...aro.org> [190411 19:21]:
> > > On 10/04/2019 22:07, Tony Lindgren wrote:
> > > > Hi,
> > > > 
> > > > * Daniel Lezcano <daniel.lezcano@...aro.org> [190410 17:02]:
> > > >> can you ask for an acked-by before pulling a patch in your tree?
> > > > 
> > > > I certainly do ask and wait for acks where possible :)
> > > 
> > > Ok, I may have missed them.
> > > 
> > > > Note that I have not applied this patch. I just added
> > > > Keerthy to Cc on this thread so maybe you misread the
> > > > message earlier. My comment "seems like no other
> > > > takers" was for Ladislav regarding somebody picking up
> > > > his earlier work, not for picking up this patch :)
> > > 
> > > Actually I was referring to the commit 592ea6bd1fad. Anyway as stated
> > > above I could have miss your call.
> > 
> > Hmm so commit 592ea6bd1fad was part of the PWM timer series
> > that was posted several times from late 2017 to end of
> > February 2018. I did not get any timer related acks or
> > comments so I applied it together with the PWM timer
> > changes.
> > 
> > I'm guessing you may have accidentally checked out some
> > older deja-vu branch from about a year ago? Commit
> > 592ea6bd1fad is not related to this fix.. :)
> > 
> 
> Just for the record, I said this patch fixes 592ea6bd1fad because
> 592ea6bd1fad should have been marked this function as static, which
> would have exposed that this function was unused and it could have
> been removed at that time. I know it is a bit of a stretch for this
> commit (would be more appropriate for 008258d995a6 to have it) but
> that was my logic behind it. Not opposed to having it removed before
> committing.

Oh OK yes they should have all become static with the PWM
series.

Regards,

Tony