lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190414144931.GA14344@avx2> Date: Sun, 14 Apr 2019 17:49:31 +0300 From: Alexey Dobriyan <adobriyan@...il.com> To: Thomas Gleixner <tglx@...utronix.de> Cc: LKML <linux-kernel@...r.kernel.org>, Josh Poimboeuf <jpoimboe@...hat.com>, x86@...nel.org, Andy Lutomirski <luto@...nel.org>, Steven Rostedt <rostedt@...dmis.org>, Alexander Potapenko <glider@...gle.com>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [RFC patch 21/41] proc: Simplify task stack retrieval On Wed, Apr 10, 2019 at 12:28:15PM +0200, Thomas Gleixner wrote: > @@ -430,20 +429,16 @@ static int proc_pid_stack(struct seq_fil > if (!entries) > return -ENOMEM; > > - trace.nr_entries = 0; > - trace.max_entries = MAX_STACK_TRACE_DEPTH; > - trace.entries = entries; > - trace.skip = 0; > - > err = lock_trace(task); > if (!err) { > - unsigned int i; > + unsigned int i, nent; > > - save_stack_trace_tsk(task, &trace); > + nent = stack_trace_save_tsk(task, entries, > + MAX_STACK_TRACE_DEPTH, 0); > > - for (i = 0; i < trace.nr_entries; i++) { > + for (i = 0; i < nent; i++) > seq_printf(m, "[<0>] %pB\n", (void *)entries[i]); > - } > + I only object to {} removal. The rule of mandatory {} that new languages have adopted is pretty cool. Otherwise Reviewed-by: Alexey Dobriyan <adobriyan@...il.com>
Powered by blists - more mailing lists