linux-kernel - Re: [PATCH 01/12] arm-cci: add missing of_node_put after of_device_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c56bdcb-9354-c719-13df-38b5f1974f10@web.de>
Date:   Sun, 14 Apr 2019 16:45:11 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Julia Lawall <Julia.Lawall@...6.fr>,
        Robin Murphy <robin.murphy@....com>, linux@....linux.org.uk
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 01/12] arm-cci: add missing of_node_put after
 of_device_is_available

> @@ -538,8 +538,10 @@  static int cci_probe(void)
>  	struct resource res;
>
>  	np = of_find_matching_node(NULL, arm_cci_matches);
> -	if (!of_device_is_available(np))
> +	if (!of_device_is_available(np)) {
> +		of_node_put(np);
>  		return -ENODEV;
> +	}
>
>  	ret = of_address_to_resource(np, 0, &res);
>  	if (!ret) {

How do you think about to move this function call to an additional jump target
for the desired exception handling?

Regards,
Markus