linux-kernel - [PATCH] [PATCHv1] drivers: edac: This patch fix the following checkpatch warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1555267310-21510-1-git-send-email-mohankumar718@gmail.com>
Date:   Sun, 14 Apr 2019 21:41:50 +0300
From:   Mohan Kumar <mohankumar718@...il.com>
To:     bp@...en8.de
Cc:     mchehab@...nel.org, james.morse@....com,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] [PATCHv1] drivers: edac: This patch fix the following checkpatch warning.

Use pr_warn instead of printk

WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
        then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Signed-off-by: Mohan Kumar <mohankumar718@...il.com>
---
 drivers/edac/x38_edac.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c
index cc779f3..4c855c0 100644
--- a/drivers/edac/x38_edac.c
+++ b/drivers/edac/x38_edac.c
@@ -14,6 +14,7 @@
 #include <linux/pci.h>
 #include <linux/pci_ids.h>
 #include <linux/edac.h>
+#include <linux/netdevice.h>
 
 #include <linux/io-64-nonatomic-lo-hi.h>
 #include "edac_module.h"
@@ -260,7 +261,7 @@ static void __iomem *x38_map_mchbar(struct pci_dev *pdev)
 	u.mchbar &= X38_MCHBAR_MASK;
 
 	if (u.mchbar != (resource_size_t)u.mchbar) {
-		printk(KERN_ERR
+		pr_err(
 			"x38: mmio space beyond accessible range (0x%llx)\n",
 			(unsigned long long)u.mchbar);
 		return NULL;
@@ -268,7 +269,7 @@ static void __iomem *x38_map_mchbar(struct pci_dev *pdev)
 
 	window = ioremap_nocache(u.mchbar, X38_MMR_WINDOW_SIZE);
 	if (!window)
-		printk(KERN_ERR "x38: cannot map mmio space at 0x%llx\n",
+		pr_err("x38: cannot map mmio space at 0x%llx\n",
 			(unsigned long long)u.mchbar);
 
 	return window;
-- 
2.7.4