lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 15 Apr 2019 13:18:56 -0700
From:   Andy Lutomirski <>
To:     Pavel Machek <>
Cc:     Greg Kroah-Hartman <>,
        LKML <>,
        stable <>,
        Jarkko Nikula <>,
        Andy Lutomirski <>,
        "Rafael J. Wysocki" <>,
        Thomas Gleixner <>,
        Borislav Petkov <>,
        Josh Poimboeuf <>,
        Peter Zijlstra <>,
        "Rafael J. Wysocki" <>,
        Zhang Rui <>,
        Ingo Molnar <>,
        Sasha Levin <>,
        Linus Torvalds <>
Subject: Re: [PATCH 4.14 05/69] x86/power: Make restore_processor_context() sane

On Mon, Apr 15, 2019 at 1:04 PM Pavel Machek <> wrote:
> On Mon 2019-04-15 20:58:23, Greg Kroah-Hartman wrote:
> > [ Upstream commit 7ee18d677989e99635027cee04c878950e0752b9 ]
> >
> > My previous attempt to fix a couple of bugs in __restore_processor_context():
> >
> >   5b06bbcfc2c6 ("x86/power: Fix some ordering bugs in __restore_processor_context()")
> >
> > ... introduced yet another bug, breaking suspend-resume.
> >
> > Rather than trying to come up with a minimal fix, let's try to clean it up
> > for real.  This patch fixes quite a few things:
> 5b06bbcfc2c6 fixed theoretical bug; rather than porting it to stable
> than fixing it up, it would be better not to port it to stable in the
> first place or simply revert it there.

Are you sure about that?  The bug was reported by real users who had
their systems really crash:

And we had a report that the bug got backported:

And if we're going to backport some of the fix, we should definitely
backport the whole set to avoid having the -stable kernels be in a
state that was never in any released kernel.


Powered by blists - more mailing lists