linux-kernel - Re: [PATCH 4.14 04/69] x86/power/32: Move SYSENTER MSR restoration to fix_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190415220755.GW11568@sasha-vm>
Date:   Mon, 15 Apr 2019 18:07:55 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bpetkov@...e.de>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Zhang Rui <rui.zhang@...el.com>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH 4.14 04/69] x86/power/32: Move SYSENTER MSR restoration
 to fix_processor_context()

On Mon, Apr 15, 2019 at 10:07:47PM +0200, Pavel Machek wrote:
>On Mon 2019-04-15 20:58:22, Greg Kroah-Hartman wrote:
>> [ Upstream commit 896c80bef4d3b357814a476663158aaf669d0fb3 ]
>>
>> x86_64 restores system call MSRs in fix_processor_context(), and
>> x86_32 restored them along with segment registers.  The 64-bit
>> variant makes more sense, so move the 32-bit code to match the
>> 64-bit code.
>>
>> No side effects are expected to runtime behavior.
>
>Again, this is cleanup, not a bugfix.

Indeed, these two are just preparatory patches rather than fixes.
Patches that come later need these.

--
Thanks,
Sasha