linux-kernel - Re: [PATCH] hwmon (occ): Fix extended status bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Apr 2019 17:17:58 -0500
From:   Eddie James <eajames@...ux.ibm.com>
To:     Guenter Roeck <linux@...ck-us.net>, Lei YU <mine260309@...il.com>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>
Subject: Re: [PATCH] hwmon (occ): Fix extended status bits


On 4/15/19 3:28 PM, Guenter Roeck wrote:
> On Mon, Apr 15, 2019 at 06:37:20PM +0800, Lei YU wrote:
>> The occ's extended status is checked and shown as sysfs attributes. But
>> the code was incorrectly checking the "status" bits.
>> Fix it by checking the "ext_status" bits.
>>
>> Signed-off-by: Lei YU <mine260309@...il.com>
> Looks ok to me, but can I get a confirmation from someone at IBM ?


Yes. Thanks Lei.


Reviewed-by: Eddie James <eajames@...ux.ibm.com>


>
> Thanks,
> Guenter
>
>> ---
>>   drivers/hwmon/occ/sysfs.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/hwmon/occ/sysfs.c b/drivers/hwmon/occ/sysfs.c
>> index fe3d15e..a71ca94 100644
>> --- a/drivers/hwmon/occ/sysfs.c
>> +++ b/drivers/hwmon/occ/sysfs.c
>> @@ -42,16 +42,16 @@ static ssize_t occ_sysfs_show(struct device *dev,
>>   		val = !!(header->status & OCC_STAT_ACTIVE);
>>   		break;
>>   	case 2:
>> -		val = !!(header->status & OCC_EXT_STAT_DVFS_OT);
>> +		val = !!(header->ext_status & OCC_EXT_STAT_DVFS_OT);
>>   		break;
>>   	case 3:
>> -		val = !!(header->status & OCC_EXT_STAT_DVFS_POWER);
>> +		val = !!(header->ext_status & OCC_EXT_STAT_DVFS_POWER);
>>   		break;
>>   	case 4:
>> -		val = !!(header->status & OCC_EXT_STAT_MEM_THROTTLE);
>> +		val = !!(header->ext_status & OCC_EXT_STAT_MEM_THROTTLE);
>>   		break;
>>   	case 5:
>> -		val = !!(header->status & OCC_EXT_STAT_QUICK_DROP);
>> +		val = !!(header->ext_status & OCC_EXT_STAT_QUICK_DROP);
>>   		break;
>>   	case 6:
>>   		val = header->occ_state;