linux-kernel - Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190416192408.0e321563@xps13>
Date:   Tue, 16 Apr 2019 19:24:08 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

Hi Gustavo,

"Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote on Mon, 15 Apr
2019 07:57:11 -0500:

> Hi Miquel,
> 
> On 4/15/19 3:44 AM, Miquel Raynal wrote:
> > Hi Gustavo,
> > 
> > "Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote on Wed, 10 Apr
> > 2019 16:16:51 -0500:
> >   
> >> Hi all,
> >>
> >> If no one cares I'll add this to my tree for 5.2.  
> > 
> > Which tree are you talking about?
> >   
> 
> This one:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp
> 
> > Please let the MTD maintainers take patches through their tree. We
> > might be late but this is definitely not a good reason to bypass us.
> >   
> It's a bit confusing when patches are being ignored for more than two
> months:
> 
> https://lore.kernel.org/patchwork/patch/1040099/
> https://lore.kernel.org/patchwork/patch/1040100/
> https://lore.kernel.org/patchwork/patch/1040098/
> 

Patches posted at -rc6 right before the last release? Come on! Gustavo,
we always spend more time for you than for other contributors because we
do not trust your changes. We could apply them blindly but we don't do
that for other (worthy) contributions, so why shall we do it for you?

I think you could at least flag these changes as "automatic and
unverified" in the commit log so that when git blaming, people could
know that the additional explicit /* fallthrough */ comment might be
wrong and was just added in order to limit the number of warnings when
enabling the extra GCC warning.

> Certainly, Richard Weinberger replied to this one. But I couldn't
> find a tree to which this patch was applied, in case it actually
> was.
> 
> It's a common practice for maintainers to reply saying that a patch
> has been finally applied, and in most cases they also explicitly
> mention the tree and branch to which it was applied. All this info
> is really helpful for people working all over the tree.

It is common practice for contributors to understand what they
are doing before submitting a change and this is something that you
clearly don't try to do.


Thanks,
Miquèl