lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 16 Apr 2019 03:23:38 +0000
From:   Anson Huang <anson.huang@....com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "rui.zhang@...el.com" <rui.zhang@...el.com>,
        "edubezval@...il.com" <edubezval@...il.com>,
        Aisheng Dong <aisheng.dong@....com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        Peng Fan <peng.fan@....com>,
        Daniel Baluta <daniel.baluta@....com>,
        "horms+renesas@...ge.net.au" <horms+renesas@...ge.net.au>,
        "heiko@...ech.de" <heiko@...ech.de>,
        Andy Gross <andy.gross@...aro.org>,
        "maxime.ripard@...tlin.com" <maxime.ripard@...tlin.com>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "jagan@...rulasolutions.com" <jagan@...rulasolutions.com>,
        "enric.balletbo@...labora.com" <enric.balletbo@...labora.com>,
        "ezequiel@...labora.com" <ezequiel@...labora.com>,
        "stefan.wahren@...e.com" <stefan.wahren@...e.com>,
        "marc.w.gonzalez@...e.fr" <marc.w.gonzalez@...e.fr>,
        "olof@...om.net" <olof@...om.net>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
CC:     dl-linux-imx <linux-imx@....com>
Subject: RE: [EXT] Re: [PATCH RESEND V11 2/4] thermal: imx_sc: add i.MX system
 controller thermal support

Hi, Daniel

Best Regards!
Anson Huang

> -----Original Message-----
> 
> On 10/04/2019 09:43, Anson Huang wrote:
> > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
> > inside, the system controller is in charge of controlling power, clock
> > and thermal sensors etc..
> >
> > This patch adds i.MX system controller thermal driver support, Linux
> > kernel has to communicate with system controller via MU (message unit)
> > IPC to get each thermal sensor's temperature, it supports multiple
> > sensors which are passed from device tree, please see the binding doc
> > for details.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > ---
> > Changes since V10:
> >       - remove "imx,sensor-resource-id" property, put the HW resource ID
> inside thermal-zones node,
> >         and driver needs to parse the phandle argument to get HW resource ID
> and use it to register
> >         thermal zone.
> > ---
> >  drivers/thermal/Kconfig          |  11 +++
> >  drivers/thermal/Makefile         |   1 +
> >  drivers/thermal/imx_sc_thermal.c | 159
> > +++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 171 insertions(+)
> >  create mode 100644 drivers/thermal/imx_sc_thermal.c
> >
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index
> > 653aa27..4e4fa7e 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -223,6 +223,17 @@ config IMX_THERMAL
> >         cpufreq is used as the cooling device to throttle CPUs when the
> >         passive trip is crossed.
> >
> > +config IMX_SC_THERMAL
> > +     tristate "Temperature sensor driver for NXP i.MX SoCs with System
> Controller"
> > +     depends on (ARCH_MXC && IMX_SCU) || COMPILE_TEST
> > +     depends on OF
> > +     help
> > +       Support for Temperature Monitor (TEMPMON) found on NXP i.MX
> SoCs with
> > +       system controller inside, Linux kernel has to communicate with system
> > +       controller via MU (message unit) IPC to get temperature from thermal
> > +       sensor. It supports one critical trip point and one
> > +       passive trip point for each thermal sensor.
> > +
> >  config MAX77620_THERMAL
> >       tristate "Temperature sensor driver for Maxim MAX77620 PMIC"
> >       depends on MFD_MAX77620
> > diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile index
> > 486d682..4062627 100644
> > --- a/drivers/thermal/Makefile
> > +++ b/drivers/thermal/Makefile
> > @@ -40,6 +40,7 @@ obj-$(CONFIG_DB8500_THERMAL)        +=
> db8500_thermal.o
> >  obj-$(CONFIG_ARMADA_THERMAL) += armada_thermal.o
> >  obj-$(CONFIG_TANGO_THERMAL)  += tango_thermal.o
> >  obj-$(CONFIG_IMX_THERMAL)    += imx_thermal.o
> > +obj-$(CONFIG_IMX_SC_THERMAL) += imx_sc_thermal.o
> >  obj-$(CONFIG_MAX77620_THERMAL)       += max77620_thermal.o
> >  obj-$(CONFIG_QORIQ_THERMAL)  += qoriq_thermal.o
> >  obj-$(CONFIG_DA9062_THERMAL) += da9062-thermal.o diff --git
> > a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
> > new file mode 100644
> > index 0000000..0af0f09
> > --- /dev/null
> > +++ b/drivers/thermal/imx_sc_thermal.c
> > @@ -0,0 +1,159 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright 2018-2019 NXP.
> > + */
> > +
> > +#include <linux/err.h>
> > +#include <linux/firmware/imx/sci.h>
> > +#include <linux/module.h>
> > +#include <linux/of.h>
> > +#include <linux/of_device.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/slab.h>
> > +#include <linux/thermal.h>
> > +
> > +#include "thermal_core.h"
> > +
> > +#define IMX_SC_MISC_FUNC_GET_TEMP    13
> > +#define IMX_SC_C_TEMP                        0
> > +
> > +static struct imx_sc_ipc *thermal_ipc_handle;
> > +
> > +struct imx_sc_sensor {
> > +     struct thermal_zone_device *tzd;
> > +     u32 resource_id;
> > +};
> > +
> > +struct req_get_temp {
> > +     u16 resource_id;
> > +     u8 type;
> > +} __packed;
> > +
> > +struct resp_get_temp {
> > +     u16 celsius;
> > +     u8 tenths;
> > +} __packed;
> > +
> > +struct imx_sc_msg_misc_get_temp {
> > +     struct imx_sc_rpc_msg hdr;
> > +     union {
> > +             struct req_get_temp req;
> > +             struct resp_get_temp resp;
> > +     } data;
> > +} __packed;
> 
> Do we really need to add the __packed for the struct imx_sc_sensor and the
> struct imx_sc_msg_misc_get_temp?

I think struct imx_sc_msg_misc_get_temp is no need to add __packed, remove it in V12.

> 
> > +static int imx_sc_thermal_get_temp(void *data, int *temp) {
> > +     struct imx_sc_msg_misc_get_temp msg;
> > +     struct imx_sc_rpc_msg *hdr = &msg.hdr;
> > +     struct imx_sc_sensor *sensor = data;
> > +     int ret;
> > +
> > +     msg.data.req.resource_id = sensor->resource_id;
> > +     msg.data.req.type = IMX_SC_C_TEMP;
> > +
> > +     hdr->ver = IMX_SC_RPC_VERSION;
> > +     hdr->svc = IMX_SC_RPC_SVC_MISC;
> > +     hdr->func = IMX_SC_MISC_FUNC_GET_TEMP;
> > +     hdr->size = 2;
> > +
> > +     ret = imx_scu_call_rpc(thermal_ipc_handle, &msg, true);
> > +     if (ret) {
> > +             pr_err("read temp sensor %d failed, ret %d\n",
> > +                     sensor->resource_id, ret);
> > +             return ret;
> > +     }
> > +
> > +     *temp = msg.data.resp.celsius * 1000 + msg.data.resp.tenths *
> > + 100;
> > +
> > +     return 0;
> > +}
> > +
> > +static const struct thermal_zone_of_device_ops imx_sc_thermal_ops = {
> > +     .get_temp = imx_sc_thermal_get_temp, };
> > +
> > +static int imx_sc_thermal_get_sensor_id(struct device_node
> > +*sensor_np, u32 *id) {
> > +     struct of_phandle_args sensor_specs;
> > +     int ret;
> > +
> > +     ret = of_parse_phandle_with_args(sensor_np,
> > +                                      "thermal-sensors",
> > +                                      "#thermal-sensor-cells",
> > +                                      0,
> > +                                      &sensor_specs);
> > +     if (ret)
> > +             return ret;
> > +
> > +     if (sensor_specs.args_count >= 1) {
> > +             *id = sensor_specs.args[0];
> > +             WARN(sensor_specs.args_count > 1,
> > +                  "%pOFn: too many cells in sensor specifier %d\n",
> > +                  sensor_specs.np, sensor_specs.args_count);
> > +     } else {
> > +             return -EINVAL;
> > +     }
> > +
> > +     return 0;
> > +}
> > +
> > +static int imx_sc_thermal_probe(struct platform_device *pdev) {
> > +     struct device_node *np, *child;
> > +     int ret;
> > +
> > +     ret = imx_scu_get_handle(&thermal_ipc_handle);
> > +     if (ret)
> > +             return ret;
> > +
> > +     np = of_find_node_by_name(NULL, "thermal-zones");
> > +     if (!np)
> > +             return -ENODEV;
> > +
> > +     for_each_available_child_of_node(np, child) {
> > +             struct imx_sc_sensor *sensor =
> > +                     devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL);
> > +             if (!sensor)
> > +                     return -ENOMEM;
> > +
> > +             ret = imx_sc_thermal_get_sensor_id(child,
> > + &sensor->resource_id);
> 
> 
> IMO, this function should be generic and added to the of-thermal.c

Make sense, I have moved it to a new patch of adding new API for getting sensor ID in V12 patch series.

Thanks,
Anson

> 
> > +             if (ret < 0) {
> > +                     dev_err(&pdev->dev,
> > +                             "failed to get valid sensor resource id: %d\n",
> > +                             ret);
> > +                     break;
> > +             }
> > +
> > +             sensor->tzd = devm_thermal_zone_of_sensor_register(&pdev-
> >dev,
> > +                                                                sensor->resource_id,
> > +                                                                sensor,
> > +                                                                &imx_sc_thermal_ops);
> > +             if (IS_ERR(sensor->tzd)) {
> > +                     dev_err(&pdev->dev, "failed to register thermal zone\n");
> > +                     ret = PTR_ERR(sensor->tzd);
> > +                     break;
> > +             }
> > +     }
> > +
> > +     return ret;
> > +}
> >
> > +static const struct of_device_id imx_sc_thermal_table[] = {
> > +     { .compatible = "fsl,imx-sc-thermal", },
> > +     {}
> > +};
> > +MODULE_DEVICE_TABLE(of, imx_sc_thermal_table);
> > +
> > +static struct platform_driver imx_sc_thermal_driver = {
> > +             .probe = imx_sc_thermal_probe,
> > +             .driver = {
> > +                     .name = "imx-sc-thermal",
> > +                     .of_match_table = imx_sc_thermal_table,
> > +             },
> > +};
> > +module_platform_driver(imx_sc_thermal_driver);
> > +
> > +MODULE_AUTHOR("Anson Huang <Anson.Huang@....com>");
> > +MODULE_DESCRIPTION("Thermal driver for NXP i.MX SoCs with system
> > +controller"); MODULE_LICENSE("GPL v2");
> >
> 
> 
> --
> 
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> linaro.org%2F&amp;data=02%7C01%7Canson.huang%40nxp.com%7Cc8cd5f
> 6ddab14679fa8308d6c1ddf788%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C
> 0%7C0%7C636909556419507623&amp;sdata=ENeuLStvLI2b3qmoMaVd80PO
> Z3D5SDP4SLsMEgyCSmo%3D&amp;reserved=0> Linaro.org │ Open source
> software for ARM SoCs
> 
> Follow Linaro:
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> facebook.com%2Fpages%2FLinaro&amp;data=02%7C01%7Canson.huang%4
> 0nxp.com%7Cc8cd5f6ddab14679fa8308d6c1ddf788%7C686ea1d3bc2b4c6fa9
> 2cd99c5c301635%7C0%7C0%7C636909556419517628&amp;sdata=VfEhJa%2
> F5VBvhNb0A43FSmbUUsfHuP7Sb3iC0MAdT1zQ%3D&amp;reserved=0>
> Facebook |
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitte
> r.com%2F%23!%2Flinaroorg&amp;data=02%7C01%7Canson.huang%40nxp.c
> om%7Cc8cd5f6ddab14679fa8308d6c1ddf788%7C686ea1d3bc2b4c6fa92cd99c
> 5c301635%7C0%7C0%7C636909556419517628&amp;sdata=YYFrIOw1ad29foi
> EtLdpY83zehoSRJniUCfJGKNJer8%3D&amp;reserved=0> Twitter |
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> linaro.org%2Flinaro-
> blog%2F&amp;data=02%7C01%7Canson.huang%40nxp.com%7Cc8cd5f6ddab
> 14679fa8308d6c1ddf788%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C636909556419517628&amp;sdata=hUHkrV00%2FDOuCuYND7%2BtFFwK
> UBM7hvrgZXFSPm23g5M%3D&amp;reserved=0> Blog

Powered by blists - more mailing lists