linux-kernel - Re: [PATCH v1] mfd: intel-lpss: Add Intel Comet Lake PCI IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vfw8-jfzgOBwyTk6E5sqsSxh1NVPnLdQHyZJZneruT3uA@mail.gmail.com>
Date:   Tue, 16 Apr 2019 10:55:50 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Evan Green <evgreen@...omium.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Lee Jones <lee.jones@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Subject: Re: [PATCH v1] mfd: intel-lpss: Add Intel Comet Lake PCI IDs

On Tue, Apr 16, 2019 at 6:10 AM Evan Green <evgreen@...omium.org> wrote:
> On Tue, Apr 9, 2019 at 11:11 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> >
> > Intel Comet Lake has the same LPSS than Intel Cannon Lake.
> > Add the new IDs to the list of supported devices.

> >  static const struct pci_device_id intel_lpss_pci_ids[] = {
> > +       /* CML */
> > +       { PCI_VDEVICE(INTEL, 0x02a8), (kernel_ulong_t)&spt_uart_info },
> > +       { PCI_VDEVICE(INTEL, 0x02a9), (kernel_ulong_t)&spt_uart_info },
> > +       { PCI_VDEVICE(INTEL, 0x02aa), (kernel_ulong_t)&spt_info },
> > +       { PCI_VDEVICE(INTEL, 0x02ab), (kernel_ulong_t)&spt_info },
> > +       { PCI_VDEVICE(INTEL, 0x02c5), (kernel_ulong_t)&bxt_i2c_info },
> > +       { PCI_VDEVICE(INTEL, 0x02c6), (kernel_ulong_t)&bxt_i2c_info },
>
> How come it's not cnl_i2c_info?

This is a good question, that's why Jarkko asked Lee to hold on until
we have confirmation about i2c timings.

-- 
With Best Regards,
Andy Shevchenko