linux-kernel - Re: [PATCH] Fix warning and undefined behavior in mmc voltage handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190416080024.GD14538@amd>
Date:   Tue, 16 Apr 2019 10:00:24 +0200
From:   Pavel Machek <pavel@....cz>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     kernel list <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...l.org>,
        Trivial patch monkey <trivial@...nel.org>
Subject: Re: [PATCH] Fix warning and undefined behavior in mmc voltage
 handling

On Tue 2019-04-16 09:48:51, Ulf Hansson wrote:
> On Fri, 12 Apr 2019 at 11:34, Pavel Machek <pavel@....cz> wrote:
> >
> > !voltage_ranges is tested for too late, allowing warning and undefined
> > behavior. Fix that.
> >
> > Signed-off-by: Pavel Machek <pavel@....cz>
> 
> Pavel, thanks for your patch.
> 
> Would you mind re-posting to linux-mmc so I can get it into the
> patchtracker. Please also change the prefix of the header to "mmc:
> core:".

Done.

> > Plus I guess author should add parenthesis in the expression. a / b /
> > c is _not_ common idiom.

Can you do something about the a / b / c situation?

> > -       num_ranges = num_ranges / sizeof(*voltage_ranges) / 2;
> > +       num_ranges = num_ranges / sizeof(*voltage_ranges) / 2;

I guess it is:
       num_ranges = (num_ranges / sizeof(*voltage_ranges)) / 2;

...but...

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)