linux-kernel - Re: [PATCH] Fix warning and undefined behavior in mmc voltage handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFp-tNhxM=RSsb3eqJhHMSV4ZMo2Chag5NFAK-d1Oi_j4g@mail.gmail.com>
Date:   Tue, 16 Apr 2019 11:28:27 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Pavel Machek <pavel@....cz>
Cc:     kernel list <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...l.org>,
        Trivial patch monkey <trivial@...nel.org>
Subject: Re: [PATCH] Fix warning and undefined behavior in mmc voltage handling

On Tue, 16 Apr 2019 at 10:00, Pavel Machek <pavel@....cz> wrote:
>
> On Tue 2019-04-16 09:48:51, Ulf Hansson wrote:
> > On Fri, 12 Apr 2019 at 11:34, Pavel Machek <pavel@....cz> wrote:
> > >
> > > !voltage_ranges is tested for too late, allowing warning and undefined
> > > behavior. Fix that.
> > >
> > > Signed-off-by: Pavel Machek <pavel@....cz>
> >
> > Pavel, thanks for your patch.
> >
> > Would you mind re-posting to linux-mmc so I can get it into the
> > patchtracker. Please also change the prefix of the header to "mmc:
> > core:".
>
> Done.

Thanks!

>
> > > Plus I guess author should add parenthesis in the expression. a / b /
> > > c is _not_ common idiom.
>
> Can you do something about the a / b / c situation?

Sure.

>
> > > -       num_ranges = num_ranges / sizeof(*voltage_ranges) / 2;
> > > +       num_ranges = num_ranges / sizeof(*voltage_ranges) / 2;
>
> I guess it is:
>        num_ranges = (num_ranges / sizeof(*voltage_ranges)) / 2;

Just send a patch on top, then I will apply it.

Kind regards
Uffe