linux-kernel - Re: [PATCH] lib/siphash.c: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9rycs66KYXhxa5t5=7B9JkrotU1MMxXDFXrxqCM27ysBw@mail.gmail.com>
Date:   Tue, 16 Apr 2019 18:03:58 +0900
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Kees Cook <keescook@...omium.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] lib/siphash.c: mark expected switch fall-throughs

On Tue, Apr 16, 2019 at 4:27 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> This patch aims to suppress up to 18 missing-break-in-switch false
> positives on some architectures.
>
> Cc: Jason A. Donenfeld <Jason@...c4.com>
> Cc: Gustavo A. R. Silva <gustavo@...eddedor.com>
> Cc: Kees Cook <keescook@...omium.org>
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>

Looks good to me, thanks for this.

Reviewed-by: Jason A. Donenfeld <Jason@...c4.com>

Perhaps Greg can take it through his tree?