linux-kernel - RE: [PATCH 3/3] iio: imu: st_lsm6dsx: Add i3c basic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13D59CF9CEBAF94592A12E8AE55501350A6159E0@DE02WEMBXB.internal.synopsys.com>
Date:   Tue, 16 Apr 2019 15:02:11 +0000
From:   Vitor Soares <vitor.soares@...opsys.com>
To:     Boris Brezillon <boris.brezillon@...labora.com>,
        Vitor Soares <vitor.soares@...opsys.com>
CC:     "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-i3c@...ts.infradead.org" <linux-i3c@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "pmeerw@...erw.net" <pmeerw@...erw.net>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "knaack.h@....de" <knaack.h@....de>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "lorenzo.bianconi83@...il.com" <lorenzo.bianconi83@...il.com>,
        "bbrezillon@...nel.org" <bbrezillon@...nel.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "joao.pinto@...opsys.com" <joao.pinto@...opsys.com>
Subject: RE: [PATCH 3/3] iio: imu: st_lsm6dsx: Add i3c basic support

Hi Boris,

From: Boris Brezillon <boris.brezillon@...labora.com>
Date: Tue, Apr 16, 2019 at 07:25:39
> > +MODULE_DEVICE_TABLE(i3c, st_lsm6dsx_i3c_ids);
> > +
> > +static struct i3c_driver st_lsm6dsx_driver = {
> > +	.driver.name = "st_lsm6dsx_i3c",
> > +	.probe = st_lsm6dsx_i3c_probe,
> > +	.id_table = st_lsm6dsx_i3c_ids,
> 
> You should probably set the pm_ops here (st_lsm6dsx_pm_ops).

Yes, I missed that. 

> 
> > +};
> > +module_i3c_driver(st_lsm6dsx_driver);
> > +
> > +MODULE_AUTHOR("Vitor Soares <vitor.soares@...opsys.com>");
> > +MODULE_DESCRIPTION("STMicroelectronics st_lsm6dsx i3c driver");
> > +MODULE_LICENSE("GPL v2");
> > +
> 
> You can remove this blank line.

Thanks for your feedback.

Best regards,
Vitor Soares