linux-kernel - Re: [PATCH 1/3] remap: Add I3C bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190416153948.GF4834@sirena.org.uk>
Date:   Tue, 16 Apr 2019 16:39:48 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Vitor Soares <vitor.soares@...opsys.com>
Cc:     linux-iio@...r.kernel.org, linux-i3c@...ts.infradead.org,
        linux-kernel@...r.kernel.org, pmeerw@...erw.net, lars@...afoo.de,
        knaack.h@....de, jic23@...nel.org, lorenzo.bianconi83@...il.com,
        bbrezillon@...nel.org, rafael@...nel.org,
        gregkh@...uxfoundation.org, joao.pinto@...opsys.com
Subject: Re: [PATCH 1/3] remap: Add I3C bus support

On Mon, Apr 15, 2019 at 09:19:39PM +0200, Vitor Soares wrote:

> +++ b/drivers/base/regmap/regmap-i3c.c
> @@ -0,0 +1,62 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2018 Synopsys, Inc. and/or its affiliates.

Please make the entire header C++ style so it looks more consistent.
Otherwise this looks good modulo Boris' comment; I'm fine with leaving
extra modes for later so long as they can be introduced without
disrupting existing users so the only question there would be if we
should name the init function in some way that's specific to the I/O
mode being used here.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)