linux-kernel - Re: [PATCH V1 3/3] regulator: slg51000: add slg51000 regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190417154905.GD5703@sirena.org.uk>
Date:   Wed, 17 Apr 2019 16:49:05 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Eric Hyeung Dong Jeong <eric.jeong.opensource@...semi.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        DEVICETREE <devicetree@...r.kernel.org>,
        LINUX-KERNEL <linux-kernel@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        Support Opensource <Support.Opensource@...semi.com>
Subject: Re: [PATCH V1 3/3] regulator: slg51000: add slg51000 regulator driver

On Wed, Apr 17, 2019 at 11:25:29AM +0000, Eric Hyeung Dong Jeong wrote:
> On Wednesday, April 17, 2019 12:25 AM +0900, Mark Brown wrote:

> > This looks like it should be a get_status() operation as it's reading
> > status bits rather than the command we sent to the device - for that
> > just use regulator_is_enabled_regmap().

> I thought that it needs to return current status of a regulator when the function is called.
> I am wondering that the *is_enabled()* function is just to check 
> If a regulator has been turned on or not rather than getting current status of the regulator.

It should say if we told the hardware to enable the regulator so the
former - basically, is the hardware in the same state it'd be in after
we called _enable() or _disable().  If there's a fault then that should
only affect is_enabled() if it resets the enable bit that _enable() set.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)